terraform test: fix crash when non-applyable plans are applied #36582
+36
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
added
the
1.11-backport
SarahFrench
approved these changes
Feb 26, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash in 1.11 branch that occurs when a run block in a test file fails due to a non-applyable plan. It later tries to deference the null state and crashes. This was already fixed in
mainduring a larger refactor in which the actual crash wasn't detected, so I'm pushing directly to 1.11.We shouldn't merge this until after the 1.11.0 release happens later this week, with the target release for this PR being 1.11.1 next week.
I will forward port the test that was added here so we don't accidentally cause a regression in main.
Fixes #
Target Release
1.11.1
CHANGELOG entry