Vim plugin reorg #94
Vim plugin reorg #94
Conversation
Plugin removed: coffee script support (it's 2020!) Altered plugin: JSX language support
| Plug 'adamlowe/vim-slurper' | ||
|
|
||
| " Support tab completion | ||
| " TODO: is there a better tab completion plugin? |
There was a problem hiding this comment.
I would remove this TODO, and create an issue if you feel strongly about supertab.
A quick google search for "supertab alternative" yielded me the following 2 libraries. From a cursory glance, I'm a fan of the latter as it supports Neovim and it has pretty active development.
.vimbundle
Outdated
| " a = 1 | ||
| " back = 3 | ||
| " | ||
| " Which is a pattern that disgusts me. So I will be removing this to an |
There was a problem hiding this comment.
Oh shoot, Lol. I forgot to moderate my snark. I had originally planned for this to just be my modified version of dotmatrix. 😨
.vimbundle
Outdated
| Plug 'nelstrom/vim-textobj-rubyblock' | ||
| Plug 'pangloss/vim-javascript' | ||
|
|
||
| " You should be using Rg |
There was a problem hiding this comment.
Could you expand on this a little bit?
.vimbundle
Outdated
| Plug 'jgdavey/vim-weefactor' | ||
|
|
||
| " This is a plugin to allow user defined text objects, which is really friggin |
There was a problem hiding this comment.
, which is really friggin
I would delete this
.vimbundle
Outdated
| Plug 'tpope/vim-commentary' | ||
|
|
||
| " Syntax highlighting and editing commands for cucumber files | ||
| " should go with things that I don't normally use |
There was a problem hiding this comment.
remove this line
Edit: just 117
|
Hey Phil, thanks for taking the time to put this together. I definitely laughed at a few of your extremely witty comments 😂 I'm not sure if you are done with the PR yet, however I already started to leave some feedback. In addition to what I've already mentioned, I would request that you remove comments that state an opinion about a plugin. Other than that, looks good 👍 |
Reorganize and document the current plugins for vim.
We remove the mxw/vim-jsx plugin as it is deprecated and broken according to the README. The replacement is the suggested plugin.
Additionally we just removed outright the coffeescript plugin.
To help with organizing we added
foldmethod=markerfor vim files so that the vimbundle loads with some organizing folds around logically grouped plugins. This helps with readability with the inline documentation of the plugins.Any feedback on the documentation is welcome. The goal was to try and synthesize the most useful parts of the plugins so that anyone could read through and get a sense of the rationale behind each plugin being a part of our core workflow.