Skip to content

Strip prefixes added by DuplicateRecordFields #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kozak
Copy link

@kozak kozak commented May 17, 2025

Fix for: #4547

DuplicateRecordFields adds $sel:...:fieldName to disambiguate record selectors. The selectors are included in the inlay hints making them slightly confusing:

image

@kozak kozak requested a review from ozkutuk as a code owner May 17, 2025 17:25
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this issue!

Just one comment.

@kozak kozak requested a review from wz1000 as a code owner May 19, 2025 07:43
@kozak
Copy link
Author

kozak commented May 19, 2025

Thanks for the review. Applied your comments.

@fendor fendor enabled auto-merge (squash) May 22, 2025 13:24
@fendor fendor disabled auto-merge May 23, 2025 13:53
@fendor
Copy link
Collaborator

fendor commented May 23, 2025

@kozak Sorry, #4586 caused conflicts, could you rebase the PR?

Apologies for merging master into your branch, I thought this PR would get merged already,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants