Skip to content

Replace writeFile with atomicFileWrite in ghcide-tests #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2025
Merged

Replace writeFile with atomicFileWrite in ghcide-tests #4710

merged 2 commits into from
Aug 27, 2025
+57 −24

Conversation

soulomoon
Copy link
Collaborator

Fix #4709

@soulomoon
Replace writeFile and writeFileUTF8 with atomicFileWriteString and at…
32bd807 
…omicFileWriteStringUTF8 for safer file operations
@soulomoon soulomoon requested a review from fendor as a code owner August 26, 2025 21:08
@soulomoon soulomoon linked an issue Aug 26, 2025 that may be closed by this pull request
Flasky test: addDependentFile #4709
Closed
@soulomoon soulomoon changed the title Replace writeFile with atomicFileWrite Replace writeFile with atomicFileWrite in ghcide-tests Aug 26, 2025
soulomoon
soulomoon commented Aug 26, 2025
View reviewed changes
fendor
fendor reviewed Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

fendor
fendor approved these changes Aug 27, 2025
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps we want an HLint rule to forbid writeFile variations, or export writeFile = atomicWriteFile from Test.Hls?

@fendor fendor merged commit 5550ca5 into master Aug 27, 2025
47 of 50 checks passed
@soulomoon
Copy link
Collaborator Author

Yes, perhaps we can enforce it in a follow up MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flasky test: addDependentFile
2 participants
@soulomoon @fendor