fix(integration-templates): show the link only for the future upgrade…

… not the current integration template (NangoHQ#2512) ## Describe your changes - The link to the template should show for the upgrade template, not the current one - Improve validation error for create-invoice ## Issue ticket number and link NAN-1428 ## Checklist before requesting a review (skip if just adding/editing APIs & templates) - [ ] I added tests, otherwise the reason is: - [ ] I added observability, otherwise the reason is: - [ ] I added analytics, otherwise the reason is:
hassan254-prog · Jul 15, 2024 · 7cf49c4 · 7cf49c4
1 parent 19b584c
commit 7cf49c4
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 160 deletions.
diff --git a/integration-templates/xero/actions/create-invoice.ts b/integration-templates/xero/actions/create-invoice.ts
@@ -6,6 +6,11 @@ export default async function runAction(nango: NangoAction, input: CreateInvoice
     const tenant_id = await getTenantId(nango);
 
     // Validate the invoices:
+    if (!input || !input.length) {
+        throw new nango.ActionError<ActionErrorResponse>({
+            message: `You must pass an array of invoices! Received: ${JSON.stringify(input)}`
+        });
+    }
 
     // 1) Contact is required
     const invalidInvoices = input.filter((x: any) => !x.external_contact_id || x.fees.length === 0);

diff --git a/integration-templates/xero/nango.yaml b/integration-templates/xero/nango.yaml
@@ -69,6 +69,7 @@ integrations:
                 scopes: accounting.transactions
                 output: InvoiceActionResponse
                 endpoint: POST /xero/invoices
+                version: 0.0.2
             update-invoice:
                 description: |
                     Updates one or more invoices in Xero. To delete an invoice

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/shared/flows.yaml b/packages/shared/flows.yaml
@@ -3549,6 +3549,7 @@ integrations:
                 scopes: accounting.transactions
                 output: InvoiceActionResponse
                 endpoint: POST /xero/invoices
+                version: 0.0.2
             update-invoice:
                 description: |
                     Updates one or more invoices in Xero. To delete an invoice

diff --git a/packages/webapp/src/pages/Integration/FlowPage.tsx b/packages/webapp/src/pages/Integration/FlowPage.tsx
@@ -430,19 +430,32 @@ export default function FlowPage(props: FlowPageProps) {
                                     <div className="flex items-center">
                                         <span className="ml-2 text-white">
                                             Template version:{' '}
-                                            <a
-                                                className="underline"
-                                                rel="noreferrer"
-                                                href={`${githubIntegrationTemplates}/${integration.provider}/${flow.type}s/${flow.name}.ts`}
-                                                target="_blank"
-                                            >
-                                                v{flow.version || '0.0.1'}
-                                            </a>
+                                            {flow.upgrade_version ? (
+                                                <span>v{flow.version || '0.0.1'}</span>
+                                            ) : (
+                                                <a
+                                                    className="underline"
+                                                    rel="noreferrer"
+                                                    href={`${githubIntegrationTemplates}/${integration.provider}/${flow.type}s/${flow.name}.ts`}
+                                                    target="_blank"
+                                                >
+                                                    v{flow.version || '0.0.1'}
+                                                </a>
+                                            )}
                                         </span>
                                         {flow.upgrade_version ? (
                                             <span className="flex items-center text-white mx-1">
                                                 {' '}
-                                                (latest: <span className="underline ml-1">v{flow.upgrade_version}</span>)
+                                                (latest:{' '}
+                                                <a
+                                                    target="_blank"
+                                                    href={`${githubIntegrationTemplates}/${integration.provider}/${flow.type}s/${flow.name}.ts`}
+                                                    rel="noreferrer"
+                                                    className="underline ml-1"
+                                                >
+                                                    v{flow.upgrade_version}
+                                                </a>
+                                                )
                                                 <Button
                                                     variant="black"
                                                     onClick={() => onScriptUprade(flow)}