Skip to content

Commit

Permalink
debug
Browse files Browse the repository at this point in the history
  • Loading branch information
krzyzacy committed Dec 27, 2018
1 parent d1474ea commit 745cf3e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions gubernator/view_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,9 @@ def get(self, prefix, job, build):
build_log, build_log_src = get_running_build_log(job, build,
external_config["prow_url"])

# 'version' might be in either started or finished.
# 'revision' might be in either started or finished.
# prefer finished.
version = finished and finished.get('version') or started and started.get('version')
version = finished and finished.get('revision') or started and started.get('revision')
commit = version and version.split('+')[-1]

refs = []
Expand Down
2 changes: 1 addition & 1 deletion gubernator/view_build_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def test_build(self):
self.assertIn('Error Goes Here', response)
self.assertIn('test.go#L123">', response) # stacktrace link works

def test_finished_has_version(self):
def test_finished_has_revision(self):
"""Test that metadata with version in finished works."""
init_build(self.BUILD_DIR, finished_has_version=True)
self.test_build()
Expand Down

0 comments on commit 745cf3e

Please sign in to comment.