Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: enhance snake_case generation #182

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Mar 8, 2025

  • Change the https://github.com/huandu/xstrings library to enhance the snake_case generation. The existing library doesn't work well with digits after characters, e.g., base64 => base_64.
  • Allow users to configure the naming style with the HASURA_PLUGIN_CONNECTOR_NAMING_STYLE environment variable

Copy link

github-actions bot commented Mar 8, 2025

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-sdk-go/cmd/hasura-ndc-go/command/internal 83%
github.com/hasura/ndc-sdk-go/cmd/hasura-ndc-go/command 34%
github.com/hasura/ndc-sdk-go/cmd/hasura-ndc-go 0%
github.com/hasura/ndc-sdk-go/cmd/hasura-ndc-go/version 43%
github.com/hasura/ndc-sdk-go/connector 54%
github.com/hasura/ndc-sdk-go/example/reference 57%
github.com/hasura/ndc-sdk-go/ndctest 51%
github.com/hasura/ndc-sdk-go/scalar 75%
github.com/hasura/ndc-sdk-go/schema 48%
github.com/hasura/ndc-sdk-go/utils 35%
Summary 52% (6735 / 12954)

Minimum allowed line rate is 40%

@hgiasac hgiasac marked this pull request as ready for review March 10, 2025 04:37
@hgiasac hgiasac merged commit 51a39c4 into main Mar 10, 2025
2 checks passed
@hgiasac hgiasac deleted the cmd/fix-codegen-snake-case-digit branch March 10, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant