Build jpackage app-image then other packages after #1319
Conversation
| // package generic app-image | ||
| executeCmd(jPackageFilePath + commonOpts + | ||
| // Options for creating the application launcher | ||
| " --main-jar ${mainJarName}" + |
There was a problem hiding this comment.
Getting a CI failure for macOS.
I see that these options will not be part of commonOpts for the executeCmd commands below, in case that could have anything to do with it.
There was a problem hiding this comment.
Getting a CI failure for macOS.
The CI build error is mv: rename desktop/build/temp-*/binaries/Haveno-*.dmg to /Users/runner/work/haveno/haveno/release/Haveno-1.0.11-mac-installer.dmg: No such file or directory, so looks like the macOS installer isn't built for some reason.
There was a problem hiding this comment.
Checking it out now
| // Copy over app-image for AppImage packaging | ||
| copy { | ||
| from jpackageAppImage | ||
| into new File(jpackageTempDir, "Haveno") |
There was a problem hiding this comment.
How is this hardcoded string "Haveno" used?
Just ensuring it's only temporary in the build process, since the application name / data directory can be customized for different networks, e.g. "Haveno-example" in other places like build.yml and HavenoExecutable.java
There was a problem hiding this comment.
By default, the AppImage building process expects a directory Haveno as a result of making an app-image directory so this is required to prevent changing the AppImage building process.
Solves #1280.
Another note for maybe the next release would be to fix up the entire
package.gradle. Its a huge mess and isn't very idiomatic with Gradle.