Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios)!: remove unused & deprecated code & styling formatting #291

Merged
merged 13 commits into from
Sep 17, 2024

Conversation

erisu
Copy link

@erisu erisu commented Sep 17, 2024

Description

  • Remove unused methods & properties/variables
  • Remove some of the deprecated code/defines/protocols of GCM
    • This PR does not rename of variables
  • Remove excessive newlines
  • Cleanup formatting

Note: The fcmSandbox is an iOS option that replaced gcmSandbox in version 2.0.0 of the phonegap-push-plugin days, but when GCM was dropped, fcmSandbox did not actual configure anything. This option can be dropped since it was never used and also FCM automatically determines the environment type.

Related Issue

N/A

Motivation and Context

Cleanup code base

How Has This Been Tested?

  • Build and run app in simulator.

Screenshots (if appropriate):

Types of changes

  • Refactor/Chore (non-breaking change, non-functionality change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu merged commit 8bae799 into master Sep 17, 2024
7 checks passed
@erisu erisu deleted the chore/remove-unused-deprecated-code branch September 17, 2024 15:36
@erisu erisu added this to the 5.0.0 milestone Nov 13, 2024
@erisu erisu added the ios Related to the iOS platform label Nov 13, 2024
Copy link

github-actions bot commented Dec 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ios Related to the iOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant