refactor(db): unify table macros (paradigmxyz#6552)

bin/reth/src/commands/db/diff.rs

@@ -64,9 +64,9 @@ impl Command {
             DatabaseArguments::default().log_level(self.second_db.log_level),
         )?;
 
-        let tables = match self.table {
-            Some(table) => vec![table],
-            None => Tables::ALL.to_vec(),
+        let tables = match &self.table {
+            Some(table) => std::slice::from_ref(table),
+            None => Tables::ALL,
         };
 
         for table in tables {

crates/storage/db/src/abstraction/table.rs

@@ -82,12 +82,17 @@ impl<T> Value for T where T: Compress + Decompress + Serialize {}
 /// It allows for the use of codecs. See [`crate::models::ShardedKey`] for a custom
 /// implementation.
 pub trait Table: Send + Sync + Debug + 'static {
-    /// Return table name as it is present inside the MDBX.
-    const NAME: &'static str;
+    /// The dynamic type of the table.
+    const TABLE: crate::Tables;
+
+    /// The table's name.
+    const NAME: &'static str = Self::TABLE.name();
+
     /// Key element of `Table`.
     ///
     /// Sorting should be taken into account when encoding this.
     type Key: Key;
+
     /// Value element of `Table`.
     type Value: Value;
 }

crates/storage/db/src/implementation/mdbx/tx.rs

@@ -6,7 +6,7 @@ use crate::{
         DatabaseEnvMetrics, Operation, TransactionMetrics, TransactionMode, TransactionOutcome,
     },
     table::{Compress, DupSort, Encode, Table, TableImporter},
-    tables::{utils::decode_one, Tables, NUM_TABLES},
+    tables::{utils::decode_one, Tables},
     transaction::{DbTx, DbTxMut},
     DatabaseError,
 };
@@ -34,7 +34,7 @@ pub struct Tx<K: TransactionKind> {
     /// Libmdbx-sys transaction.
     pub inner: Transaction<K>,
     /// Database table handle cache.
-    pub(crate) db_handles: Arc<RwLock<[Option<DBI>; NUM_TABLES]>>,
+    pub(crate) db_handles: Arc<RwLock<[Option<DBI>; Tables::COUNT]>>,
     /// Handler for metrics with its own [Drop] implementation for cases when the transaction isn't
     /// closed by [Tx::commit] or [Tx::abort], but we still need to report it in the metrics.
     ///

crates/storage/db/src/metrics.rs

@@ -1,4 +1,4 @@
-use crate::{Tables, NUM_TABLES};
+use crate::Tables;
 use dashmap::DashMap;
 use metrics::{Gauge, Histogram};
 use reth_libmdbx::CommitLatency;
@@ -25,7 +25,7 @@ impl DatabaseEnvMetrics {
     pub(crate) fn new() -> Self {
         Self {
             operations: DashMap::with_capacity_and_hasher(
-                NUM_TABLES * Operation::COUNT,
+                Tables::COUNT * Operation::COUNT,
                 BuildHasherDefault::<FxHasher>::default(),
             ),
         }