Fixes for document hierarchy presentation in QMS #7938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Ilyushchenko <[email protected]>
|
Connected to Huly®: UBERF-9417 |
Signed-off-by: Victor Ilyushchenko <[email protected]>
lexiv0re
reviewed
Feb 7, 2025
|
|
||
| export class DocumentHiearchyQuery { | ||
| queries = { | ||
| ProjectMeta: createQuery(), |
There was a problem hiding this comment.
Minor: start with lower case?
There was a problem hiding this comment.
idk, it's mapping to DocumentBundle fields, which maps fields to class names. If that's the only change, I probably wouldn't waste CI on it 😄
There was a problem hiding this comment.
So it matches the class or what's the point? :)
|
Margins look bad. Please fix them as well. Supposed to be: |
|
The rest LGTM |
Signed-off-by: Victor Ilyushchenko <[email protected]>
Signed-off-by: Victor Ilyushchenko <[email protected]>
lexiv0re
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.