Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pythonConvention HL class (cls and self) #54

Closed
wants to merge 1 commit into from
Closed

Add pythonConvention HL class (cls and self) #54

wants to merge 1 commit into from

Conversation

AloisMahdal
Copy link

These are especially useful in OOP as they help visually distinguish how
many parameters the function will be called with (in signature), or
actual state preservation from transient or return variables (in
function body).

These are especially useful in OOP as they help visually distinguish how
many parameters the function will be called with (in signature), or
actual state preservation from transient or return variables (in
function body).
@AloisMahdal
Copy link
Author

This has been hanging in my closet for a while, catching dust.

Similar to #48 except that this one takes also cls into account and uses separate highlight group.

jakar added a commit to jakar/vim-python-syntax that referenced this pull request Oct 7, 2016
@jakar
Copy link

jakar commented Oct 7, 2016

After reading some older issues and pull requests, it looks like @hdima is pretty opposed to highlighting self. So perhaps leave pythonConvention, but don't link it to Define?

jakar added a commit to jakar/vim-python-syntax that referenced this pull request Oct 7, 2016
rmariano added a commit to rmariano/python-syntax that referenced this pull request Feb 28, 2017
Apply patch from hdima#54

😃
Copy link

@rmariano rmariano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appied the patch in my fork. Looks good, thanks

@AloisMahdal AloisMahdal closed this Jun 6, 2018
@AloisMahdal AloisMahdal deleted the convention branch June 6, 2018 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants