Don't load cc_proto_library from rules_cc: not there anymore. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildifier is drunk (or too old) What it means is to load it from |
|
Is there a way to disable buildifier on those lines with a comment? Otherwise this step will always fail |
Since 6.x, the cc_proto_library() is part of default bazel rules https://bazel.build/versions/6.5.0/reference/be/c-cpp And removed as of 0.1.0 from rules_cc: https://github.com/bazelbuild/rules_cc/releases/tag/0.1.0 making the load call fail if used in a context with newer rules_cc.
hzeller
force-pushed
the
feature-20250127-no-protoc
branch
from
dd3e0b2 to
6486a8e
Compare
|
Looks like there is! |
|
So, ready to merge ? |
mikesinouye
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 6.x, the cc_proto_library() is part of default bazel rules https://bazel.build/versions/6.5.0/reference/be/c-cpp
And removed as of 0.1.0 from rules_cc:
https://github.com/bazelbuild/rules_cc/releases/tag/0.1.0
making the load call fail if used in a context with newer rules_cc.