Skip to content

Commit

Permalink
Fix retainKeys patchStrategy in apps/deployments
Browse files Browse the repository at this point in the history
  • Loading branch information
liggitt committed Oct 30, 2018
1 parent 650357a commit e6a8b29
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 3 deletions.
3 changes: 3 additions & 0 deletions api/openapi-spec/swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions staging/src/k8s.io/api/apps/v1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion staging/src/k8s.io/api/apps/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@ type DeploymentSpec struct {

// The deployment strategy to use to replace existing pods with new ones.
// +optional
Strategy DeploymentStrategy `json:"strategy,omitempty" protobuf:"bytes,4,opt,name=strategy"`
// +patchStrategy=retainKeys
Strategy DeploymentStrategy `json:"strategy,omitempty" patchStrategy:"retainKeys" protobuf:"bytes,4,opt,name=strategy"`

// Minimum number of seconds for which a newly created pod should be ready
// without any of its container crashing, for it to be considered available.
Expand Down
1 change: 1 addition & 0 deletions staging/src/k8s.io/api/apps/v1beta1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion staging/src/k8s.io/api/apps/v1beta1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,8 @@ type DeploymentSpec struct {

// The deployment strategy to use to replace existing pods with new ones.
// +optional
Strategy DeploymentStrategy `json:"strategy,omitempty" protobuf:"bytes,4,opt,name=strategy"`
// +patchStrategy=retainKeys
Strategy DeploymentStrategy `json:"strategy,omitempty" patchStrategy:"retainKeys" protobuf:"bytes,4,opt,name=strategy"`

// Minimum number of seconds for which a newly created pod should be ready
// without any of its container crashing, for it to be considered available.
Expand Down
1 change: 1 addition & 0 deletions staging/src/k8s.io/api/apps/v1beta2/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion staging/src/k8s.io/api/apps/v1beta2/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,8 @@ type DeploymentSpec struct {

// The deployment strategy to use to replace existing pods with new ones.
// +optional
Strategy DeploymentStrategy `json:"strategy,omitempty" protobuf:"bytes,4,opt,name=strategy"`
// +patchStrategy=retainKeys
Strategy DeploymentStrategy `json:"strategy,omitempty" patchStrategy:"retainKeys" protobuf:"bytes,4,opt,name=strategy"`

// Minimum number of seconds for which a newly created pod should be ready
// without any of its container crashing, for it to be considered available.
Expand Down

0 comments on commit e6a8b29

Please sign in to comment.