forked from pi-hole/pi-hole
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request pi-hole#1776 from pi-hole/release/3.2
Pi-hole core v3.2
- Loading branch information
Showing
25 changed files
with
5,029 additions
and
2,470 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,37 @@ | ||
**In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:** | ||
**In raising this issue, I confirm the following:** `{please fill the checkboxes, e.g: [X]}` | ||
|
||
- [] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md). | ||
- [] The issue I am reporting can be *replicated* | ||
- [] The issue I am reporting can be *replicated*. | ||
- [] The issue I am reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/pi-hole/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/pi-hole/issues)). | ||
|
||
**How familiar are you with the codebase?:** | ||
**How familiar are you with the the source code relevant to this issue?:** | ||
|
||
_{replace this text with a number from 1 to 10, with 1 being not familiar, and 10 being very familiar}_ | ||
`{Replace this with a number from 1 to 10. 1 being not familiar, and 10 being very familiar}` | ||
|
||
--- | ||
**[BUG REPORT | OTHER]:** | ||
**Expected behaviour:** | ||
|
||
Please [submit your feature request here](https://discourse.pi-hole.net/c/feature-requests), so it is votable by the community. It's also easier for us to track. | ||
`{A detailed description of what you expect to see}` | ||
|
||
**[BUG | ISSUE] Expected Behaviour:** | ||
**Actual behaviour:** | ||
|
||
`{A detailed description and/or screenshots of what you do see}` | ||
|
||
**[BUG | ISSUE] Actual Behaviour:** | ||
**Steps to reproduce:** | ||
|
||
`{Detailed steps of how we can reproduce this}` | ||
|
||
**[BUG | ISSUE] Steps to reproduce:** | ||
**Debug token provided by [uploading `pihole -d` log](https://discourse.pi-hole.net/t/the-pihole-command-with-examples/738#debug):** | ||
|
||
- | ||
- | ||
- | ||
- | ||
`{Alphanumeric token}` | ||
|
||
**(Optional) Debug token generated by `pihole -d`:** | ||
**Troubleshooting undertaken, and/or other relevant information:** | ||
|
||
`<token>` | ||
`{Steps of what you have done to fix this}` | ||
|
||
_This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._ | ||
> * `{Please delete this quoted section when opening your issue}` | ||
> * You must follow the template instructions. Failure to do so will result in your issue being closed. | ||
> * Please [submit any feature requests here](https://discourse.pi-hole.net/c/feature-requests), so it is votable and trackable by the community. | ||
> * Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time. | ||
> * Detail helps us understand and resolve an issue quicker, but please ensure it's relevant. | ||
> * _This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,32 @@ | ||
**By submitting this pull request, I confirm the following (please check boxes, eg [X]) _Failure to fill the template will close your PR_:** | ||
**By submitting this pull request, I confirm the following:** `{please fill any appropriate checkboxes, e.g: [X]}` | ||
|
||
***Please submit all pull requests against the `development` branch. Failure to do so will delay or deny your request*** | ||
`{Please ensure that your pull request is for the 'development' branch!}` | ||
|
||
- [] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md). | ||
- [] I have checked that [another pull request](https://github.com/pi-hole/pi-hole/pulls) for this purpose does not exist. | ||
- [] I have considered, and confirmed that this submission will be valuable to others. | ||
- [] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. | ||
- [] I give this submission freely, and claim no ownership to its content. | ||
- [] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. | ||
- [] I have made only one major change in my proposed changes. | ||
- [] I have commented my proposed changes within the code. | ||
- [] I have tested my proposed changes, and have included unit tests where possible. | ||
- [] I am willing to help maintain this change if there are issues with it later. | ||
- [] I give this submission freely and claim no ownership. | ||
- [] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) | ||
- [] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) | ||
- [] I have Signed Off all commits. ([`git commit --signoff`](https://git-scm.com/docs/git-commit#git-commit---signoff)) | ||
|
||
**How familiar are you with the codebase?:** | ||
--- | ||
|
||
_{replace this text with a number from 1 to 10, with 1 being not familiar, and 10 being very familiar}_ | ||
**What does this PR aim to accomplish?:** | ||
|
||
--- | ||
_{replace this line with your pull request content}_ | ||
`{A detailed description, screenshots (if necessary), as well as links to any relevant GitHub issues}` | ||
|
||
**How does this PR accomplish the above?:** | ||
|
||
`{A detailed description (such as a changelog) and screenshots (if necessary) of the implemented fix}` | ||
|
||
**What documentation changes (if any) are needed to support this PR?:** | ||
|
||
`{A detailed list of any necessary changes}` | ||
|
||
_This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._ | ||
> * `{Please delete this quoted section when opening your pull request}` | ||
> * You must follow the template instructions. Failure to do so will result in your issue being closed. | ||
> * Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time. | ||
> * Detail helps us understand an issue quicker, but please ensure it's relevant. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,3 @@ | |
*.swp | ||
__pycache__ | ||
.cache | ||
.pullapprove.yml |
Oops, something went wrong.