Skip to content

Commit

Permalink
HACK: input: touchscreen: edt-ft5x06: fix driver autoprobing
Browse files Browse the repository at this point in the history
Because with OF we can pass more specific
compatible flags (such as edt-ft5306) instead
of generic edt-ft5x06, when i2c-core's
of_i2c_register_devices() tries to request_module(),
it'll request it with a non-existent specific module
alias.

In order to have this driver autoprobing again, we
just need to add missing MODULE_ALIAS() entries to
edt-ft5x06 driver.

Thanks to Dmitry for noticing that it actually should
autoprobe even with of_device_id.

This patch is marked as a "HACK" since this is not
acceptable upstream and a solution is still being
debated here: https://lkml.org/lkml/2015/9/9/422

Signed-off-by: Felipe Balbi <[email protected]>
[[email protected]: tweaked to add support FT5506]
Signed-off-by: Franklin S Cooper Jr <[email protected]>
Signed-off-by: Sekhar Nori <[email protected]>
  • Loading branch information
Felipe Balbi authored and nsekhar committed Jul 8, 2016
1 parent 33ba8c5 commit 8729738
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/input/touchscreen/edt-ft5x06.c
Original file line number Diff line number Diff line change
Expand Up @@ -1087,6 +1087,10 @@ static struct i2c_driver edt_ft5x06_ts_driver = {

module_i2c_driver(edt_ft5x06_ts_driver);

MODULE_ALIAS("i2c:edt-ft5206");
MODULE_ALIAS("i2c:edt-ft5306");
MODULE_ALIAS("i2c:edt-ft5406");
MODULE_ALIAS("i2c:edt-ft5506");
MODULE_AUTHOR("Simon Budig <[email protected]>");
MODULE_DESCRIPTION("EDT FT5x06 I2C Touchscreen Driver");
MODULE_LICENSE("GPL");

0 comments on commit 8729738

Please sign in to comment.