WIP: crate: Added Ping method #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Andersen <[email protected]>
|
Hello, @pdxjohnny! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
crate.go
Outdated
| @@ -33,6 +35,14 @@ func (c *CrateDriver) Open(crate_url string) (driver.Conn, error) { | |||
| return c, nil | |||
| } | |||
|
|
|||
| func (c *CrateDriver) Ping(ctx context.Context) error { | |||
There was a problem hiding this comment.
exported method CrateDriver.Ping should have comment or be unexported
Signed-off-by: John Andersen <[email protected]>
crate.go
Outdated
| ) | ||
|
|
||
| // Crate conn structure | ||
| type CrateDriver struct { | ||
| Url string // Crate http endpoint url | ||
| Url string // Crate http endpoint url |
There was a problem hiding this comment.
struct field Url should be URL
johnandersen777
changed the title
crate: For sql.Open the URL now accepts query parameters. So far these are time.Duration formatted values for the http client's Timeout and KeepAlive parameters. Signed-off-by: John Andersen <[email protected]>
Signed-off-by: John Andersen <[email protected]>
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/herenow/go-crate/pulls/18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Andersen [email protected]