Skip to content

Commit

Permalink
Merge pull request VSCodeVim#3564 from JKillian/roadmap_notes
Browse files Browse the repository at this point in the history
docs: remove outdated notes on splits from roadmap
  • Loading branch information
jpoon authored Mar 9, 2019
2 parents 6ff07f4 + f11c587 commit 078e575
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
8 changes: 4 additions & 4 deletions ROADMAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -524,10 +524,10 @@ Since the list is too long, now we just put those already supported options here
| ------------------------- | ----------------- | ----------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------- |
| :white_check_mark: :star: | :e[dit] {file} | Edit {file}. | We will open file in a new Tab of current Grouped Editor instead of opening in current tab. |
| :white_check_mark: :star: | <ctrl-w> hl | Switching between windows. | As we don't have the concept of Window in VS Code, we are mapping these commands to switching between Grouped Editors. |
| :white_check_mark: | :sp {file} | Split current window in two. | VS Code doesn't support split Window horizontally. |
| :white_check_mark: :star: | :vsp {file} | Split vertically current window in two. | VS Code only supports three vertical window at most and that's the limitation of this command. |
| :white_check_mark: | :new | Create a new window horizontally and start editing an empty file in it. | VS Code doesn't support split Window horizontally. |
| :white_check_mark: :star: | :vne[w] | Create a new window vertically and start editing an empty file in it. | VS Code only supports three vertical window at most and that's the limitation of this command. |
| :white_check_mark: | :sp {file} | Split current window in two. | |
| :white_check_mark: :star: | :vsp {file} | Split vertically current window in two. | |
| :white_check_mark: | :new | Create a new window horizontally and start editing an empty file in it. | |
| :white_check_mark: :star: | :vne[w] | Create a new window vertically and start editing an empty file in it. | |

## Tabs

Expand Down
2 changes: 1 addition & 1 deletion test/configuration/validators/neovimValidator.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ suite('Neovim Validator', () => {
// assert
assert.equal(actual.numErrors, 0);
});
});
});
7 changes: 2 additions & 5 deletions test/state/vimState.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@ suite('VimState', () => {
const vimState = new VimState(vscode.window.activeTextEditor!);
const cursorStart = new Position(0, 0);
const cursorStop = new Position(0, 1);
const initialCursors = [
new Range(cursorStart, cursorStop),
new Range(cursorStart, cursorStop)
];
const initialCursors = [new Range(cursorStart, cursorStop), new Range(cursorStart, cursorStop)];

// test
vimState.cursors = initialCursors;
Expand All @@ -36,7 +33,7 @@ suite('VimState', () => {
const cursorStop = new Position(0, 1);
const initialCursors = [
new Range(cursorStart, cursorStop),
new Range(new Position(1, 0), new Position(1, 1))
new Range(new Position(1, 0), new Position(1, 1)),
];

// test
Expand Down

0 comments on commit 078e575

Please sign in to comment.