Skip to content

Commit

Permalink
Fix qmk flash on FreeBSD (qmk#12085)
Browse files Browse the repository at this point in the history
When the USB device is connected, FreeBSD creates not one, but three
device nodes in /dev, e.g.: /dev/ttyU0, /dev/ttyU0.init, and
/dev/ttyU0.lock.

As a result, this leads to the USB variable containing 3 paths
(and therefore, whitespace) and messages like this one:

    Device /dev/ttyU0
    /dev/ttyU0.init
    /dev/ttyU0.lock has appeared; assuming it is the controller.

This changes fixes the use of the -z flag of "[" (see test(1)). Also, it
removes undesired paths from the USB variable, leaving only
one path there (i.e., "/dev/ttyU0").
  • Loading branch information
0mp authored May 5, 2021
1 parent c6778dd commit 38b9f67
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tmk_core/avr.mk
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ define EXEC_AVRDUDE
list_devices() { \
if $(GREP) -q -s icrosoft /proc/version; then \
wmic.exe path Win32_SerialPort get DeviceID 2>/dev/null | LANG=C perl -pne 's/COM(\d+)/COM.($$1-1)/e' | sed 's!COM!/dev/ttyS!' | xargs echo -n | sort; \
elif [ "`uname`" = "FreeBSD" ]; then \
ls /dev/tty* | grep -v '\.lock$$' | grep -v '\.init$$'; \
else \
ls /dev/tty*; \
fi; \
Expand All @@ -169,7 +171,7 @@ define EXEC_AVRDUDE
TMP1=`mktemp`; \
TMP2=`mktemp`; \
list_devices > $$TMP1; \
while [ -z $$USB ]; do \
while [ -z "$$USB" ]; do \
sleep 0.5; \
printf "."; \
list_devices > $$TMP2; \
Expand Down

0 comments on commit 38b9f67

Please sign in to comment.