Skip to content

use 'var' in event listeners #10775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

use 'var' in event listeners #10775

merged 1 commit into from
Aug 18, 2025

Conversation

gavinking
Copy link
Member

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [1cba6ee]

› This message was automatically generated.

@gavinking gavinking marked this pull request as ready for review August 18, 2025 07:42
? proxyOrLoad( event, persister, keyToLoad, loadType )
: lockAndLoad( event, persister, keyToLoad, loadType );
final Object result =
event.getLockMode() == LockMode.NONE

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
LoadEvent.getLockMode
should be avoided because it has been deprecated.
Comment on lines +510 to +511
LOG.trace( "Attempting to resolve: "
+ infoString( persister, event.getEntityId(), event.getFactory() ) );

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files High

This
potentially sensitive information
is written to a log file.
@@ -58,23 +54,23 @@
throw new NullPointerException( "attempted to lock null" );
}

if ( event.getLockMode() == LockMode.WRITE ) {
final var lockMode = event.getLockMode();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
LockEvent.getLockMode
should be avoided because it has been deprecated.
@gavinking gavinking merged commit 1d00b97 into hibernate:main Aug 18, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant