Skip to content

[2.4] CCE in simple criteria query with StatelessSession due to cast to ReactiveSession #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import org.hibernate.reactive.event.ReactiveDeleteEventListener;
import org.hibernate.reactive.logging.impl.Log;
import org.hibernate.reactive.logging.impl.LoggerFactory;
import org.hibernate.reactive.session.ReactiveQueryProducer;
import org.hibernate.reactive.session.ReactiveSession;
import org.hibernate.type.CollectionType;
import org.hibernate.type.CompositeType;
Expand Down Expand Up @@ -199,7 +200,7 @@ private CompletionStage<Void> fetchAndDelete(DeleteEvent event, DeleteContext tr
}

//Object entity = persistenceContext.unproxyAndReassociate( event.getObject() );
return ( (ReactiveSession) source )
return ( (ReactiveQueryProducer) source )
.reactiveFetch( objectEvent, true )
.thenCompose( entity -> delete( event, transientEntities, entity ) );

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.hibernate.reactive.logging.impl.Log;
import org.hibernate.reactive.logging.impl.LoggerFactory;
import org.hibernate.reactive.persister.entity.impl.ReactiveEntityPersister;
import org.hibernate.reactive.session.ReactiveQueryProducer;
import org.hibernate.reactive.session.ReactiveSession;

import static org.hibernate.pretty.MessageHelper.infoString;
Expand Down Expand Up @@ -76,7 +77,7 @@ public CompletionStage<Void> reactiveOnLock(LockEvent event) throws HibernateExc
//TODO: if object was an uninitialized proxy, this is inefficient,
// resulting in two SQL selects

return ( (ReactiveSession) source ).reactiveFetch( event.getObject(), true )
return ( (ReactiveQueryProducer) source ).reactiveFetch( event.getObject(), true )
.thenCompose( entity -> reactiveOnLock( event, entity ) );
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
import org.hibernate.reactive.logging.impl.Log;
import org.hibernate.reactive.logging.impl.LoggerFactory;
import org.hibernate.reactive.persister.entity.impl.ReactiveAbstractEntityPersister;
import org.hibernate.reactive.session.ReactiveSession;
import org.hibernate.reactive.session.ReactiveQueryProducer;
import org.hibernate.type.CollectionType;
import org.hibernate.type.CompositeType;
import org.hibernate.type.Type;
Expand Down Expand Up @@ -84,7 +84,7 @@ public CompletionStage<Void> reactiveOnRefresh(RefreshEvent event, RefreshContex
// Hibernate Reactive doesn't support detached instances in refresh()
throw new IllegalArgumentException( "Unmanaged instance passed to refresh()" );
}
return ( (ReactiveSession) source )
return ( (ReactiveQueryProducer) source )
.reactiveFetch( event.getObject(), true )
.thenCompose( entity -> reactiveOnRefresh( event, refreshedAlready, entity ) );
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
import org.hibernate.query.sqm.spi.SqmParameterMappingModelResolutionAccess;
import org.hibernate.query.sqm.tree.SqmDeleteOrUpdateStatement;
import org.hibernate.query.sqm.tree.expression.SqmParameter;
import org.hibernate.reactive.engine.spi.ReactiveSharedSessionContractImplementor;
import org.hibernate.reactive.query.sqm.mutation.spi.ReactiveAbstractMutationHandler;
import org.hibernate.reactive.session.ReactiveSession;
import org.hibernate.reactive.sql.exec.internal.StandardReactiveSelectExecutor;
import org.hibernate.reactive.sql.results.spi.ReactiveListResultsConsumer;
import org.hibernate.sql.ast.SqlAstTranslator;
Expand Down Expand Up @@ -179,7 +179,7 @@ public <T> MappingModelExpressible<T> getResolvedMappingModelType(SqmParameter<T
);
lockOptions.setAliasSpecificLockMode( explicitDmlTargetAlias, lockMode );

return ( (ReactiveSession) executionContext.getSession() )
return ( (ReactiveSharedSessionContractImplementor) executionContext.getSession() )
.reactiveAutoFlushIfRequired( select.getAffectedTableNames() )
.thenCompose( v -> StandardReactiveSelectExecutor.INSTANCE.list(
select,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@
import org.hibernate.query.sqm.tree.insert.SqmInsertStatement;
import org.hibernate.query.sqm.tree.insert.SqmInsertValuesStatement;
import org.hibernate.query.sqm.tree.insert.SqmValues;
import org.hibernate.reactive.engine.spi.ReactiveSharedSessionContractImplementor;
import org.hibernate.reactive.logging.impl.Log;
import org.hibernate.reactive.logging.impl.LoggerFactory;
import org.hibernate.reactive.query.sqm.mutation.internal.ReactiveHandler;
import org.hibernate.reactive.session.ReactiveSession;
import org.hibernate.reactive.sql.exec.internal.StandardReactiveSelectExecutor;
import org.hibernate.reactive.sql.results.spi.ReactiveListResultsConsumer;
import org.hibernate.spi.NavigablePath;
Expand Down Expand Up @@ -575,7 +575,7 @@ public <T> MappingModelExpressible<T> getResolvedMappingModelType(SqmParameter<T
executionContext.getSession()
);
final JdbcOperationQuerySelect select = translator.translate( jdbcParameterBindings, executionContext.getQueryOptions() );
return ( (ReactiveSession) executionContext.getSession() )
return ( (ReactiveSharedSessionContractImplementor) executionContext.getSession() )
.reactiveAutoFlushIfRequired( select.getAffectedTableNames() )
.thenCompose( v -> StandardReactiveSelectExecutor.INSTANCE.list(
select,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import org.hibernate.persister.entity.EntityPersister;
import org.hibernate.proxy.LazyInitializer;
import org.hibernate.proxy.map.MapProxy;
import org.hibernate.reactive.session.ReactiveSession;
import org.hibernate.reactive.session.ReactiveQueryProducer;
import org.hibernate.reactive.sql.exec.spi.ReactiveRowProcessingState;
import org.hibernate.reactive.sql.results.graph.ReactiveInitializer;
import org.hibernate.sql.results.graph.AssemblerCreationState;
Expand Down Expand Up @@ -532,7 +532,7 @@ protected CompletionStage<Object> reactiveResolveEntityInstance(ReactiveEntityIn
// If this initializer owns the entity, we have to remove the entity holder,
// because the subsequent loading process will claim the entity
session.getPersistenceContextInternal().removeEntityHolder( data.getEntityKey() );
return ( (ReactiveSession) session ).reactiveInternalLoad(
return ( (ReactiveQueryProducer) session ).reactiveInternalLoad(
data.getConcreteDescriptor().getEntityName(),
data.getEntityKey().getIdentifier(),
true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import org.hibernate.proxy.LazyInitializer;
import org.hibernate.reactive.logging.impl.Log;
import org.hibernate.reactive.logging.impl.LoggerFactory;
import org.hibernate.reactive.session.ReactiveSession;
import org.hibernate.reactive.session.ReactiveQueryProducer;
import org.hibernate.reactive.sql.results.graph.ReactiveInitializer;
import org.hibernate.spi.NavigablePath;
import org.hibernate.sql.results.graph.AssemblerCreationState;
Expand Down Expand Up @@ -154,7 +154,7 @@ else if ( data.getInstance() == null ) {
data.setState( State.INITIALIZED );
final String entityName = concreteDescriptor.getEntityName();

return ( (ReactiveSession) session ).reactiveInternalLoad(
return ( (ReactiveQueryProducer) session ).reactiveInternalLoad(
entityName,
data.getEntityIdentifier(),
true,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,250 @@
/* Hibernate, Relational Persistence for Idiomatic Java
*
* SPDX-License-Identifier: Apache-2.0
* Copyright: Red Hat Inc. and Hibernate Authors
*/
package org.hibernate.reactive;

import io.vertx.junit5.Timeout;
import io.vertx.junit5.VertxTestContext;
import jakarta.persistence.*;
import jakarta.persistence.criteria.*;
import org.junit.jupiter.api.Test;

import java.util.Collection;
import java.util.List;
import java.util.Objects;

import static java.util.concurrent.TimeUnit.MINUTES;
import static org.junit.jupiter.api.Assertions.*;

@Timeout(value = 10, timeUnit = MINUTES)

public class MutinyStatelessSessionTest extends BaseReactiveTest {

@Override
protected Collection<Class<?>> annotatedEntities() {
return List.of( GuineaPig.class );
}

@Test
public void testStatelessSession(VertxTestContext context) {
GuineaPig pig = new GuineaPig( "Aloi" );
test( context, getMutinySessionFactory().withStatelessSession( ss -> ss
.insert( pig )
.chain( v -> ss.createSelectionQuery( "from GuineaPig where name=:n", GuineaPig.class )
.setParameter( "n", pig.name )
.getResultList() )
.invoke( list -> {
assertFalse( list.isEmpty() );
assertEquals( 1, list.size() );
assertThatPigsAreEqual( pig, list.get( 0 ) );
} )
.chain( v -> ss.get( GuineaPig.class, pig.id ) )
.chain( p -> {
assertThatPigsAreEqual( pig, p );
p.name = "X";
return ss.update( p );
} )
.chain( v -> ss.refresh( pig ) )
.invoke( v -> assertEquals( pig.name, "X" ) )
.chain( v -> ss.createMutationQuery( "update GuineaPig set name='Y'" ).executeUpdate() )
.chain( v -> ss.refresh( pig ) )
.invoke( v -> assertEquals( pig.name, "Y" ) )
.chain( v -> ss.delete( pig ) )
.chain( v -> ss.createSelectionQuery( "from GuineaPig", GuineaPig.class ).getResultList() )
.invoke( list -> assertTrue( list.isEmpty() ) ) )
);
}

@Test
public void testStatelessSessionWithNamed(VertxTestContext context) {
GuineaPig pig = new GuineaPig( "Aloi" );
test( context, getMutinySessionFactory().withStatelessSession( ss -> ss
.insert( pig )
.chain( v -> ss.createNamedQuery( "findbyname", GuineaPig.class )
.setParameter( "n", pig.name )
.getResultList() )
.invoke( list -> {
assertFalse( list.isEmpty() );
assertEquals( 1, list.size() );
assertThatPigsAreEqual( pig, list.get( 0 ) );
} )
.chain( v -> ss.get( GuineaPig.class, pig.id ) )
.chain( p -> {
assertThatPigsAreEqual( pig, p );
p.name = "X";
return ss.update( p );
} )
.chain( v -> ss.refresh( pig ) )
.invoke( v -> assertEquals( pig.name, "X" ) )
.chain( v -> ss.createNamedQuery( "updatebyname" ).executeUpdate() )
.chain( v -> ss.refresh( pig ) )
.invoke( v -> assertEquals( pig.name, "Y" ) )
.chain( v -> ss.delete( pig ) )
.chain( v -> ss.createNamedQuery( "findall" ).getResultList() )
.invoke( list -> assertTrue( list.isEmpty() ) ) )
);
}

@Test
public void testStatelessSessionWithNative(VertxTestContext context) {
GuineaPig pig = new GuineaPig( "Aloi" );
test( context, getMutinySessionFactory().openStatelessSession()
.chain( ss -> ss.insert( pig )
.chain( v -> ss
.createNativeQuery( "select * from Piggy where name=:n", GuineaPig.class )
.setParameter( "n", pig.name )
.getResultList() )
.invoke( list -> {
assertFalse( list.isEmpty() );
assertEquals( 1, list.size() );
assertThatPigsAreEqual( pig, list.get( 0 ) );
} )
.chain( v -> ss.get( GuineaPig.class, pig.id ) )
.chain( p -> {
assertThatPigsAreEqual( pig, p );
p.name = "X";
return ss.update( p );
} )
.chain( v -> ss.refresh( pig ) )
.invoke( v -> assertEquals( pig.name, "X" ) )
.chain( v -> ss.createNativeQuery( "update Piggy set name='Y'" )
.executeUpdate() )
.invoke( rows -> assertEquals( 1, rows ) )
.chain( v -> ss.refresh( pig ) )
.invoke( v -> assertEquals( pig.name, "Y" ) )
.chain( v -> ss.delete( pig ) )
.chain( v -> ss.createNativeQuery( "select id from Piggy" ).getResultList() )
.invoke( list -> assertTrue( list.isEmpty() ) )
.chain( v -> ss.close() ) )
);
}

@Test
public void testStatelessSessionCriteria(VertxTestContext context) {
GuineaPig pig = new GuineaPig( "Aloi" );
GuineaPig mate = new GuineaPig("Aloina");
pig.mate = mate;

CriteriaBuilder cb = getSessionFactory().getCriteriaBuilder();

CriteriaQuery<GuineaPig> query = cb.createQuery( GuineaPig.class );
Root<GuineaPig> gp = query.from( GuineaPig.class );
query.where( cb.equal( gp.get( "name" ), cb.parameter( String.class, "n" ) ) );
query.orderBy( cb.asc( gp.get( "name" ) ) );

test( context, getMutinySessionFactory().openStatelessSession()
.chain( ss -> ss.insert(mate)
.chain( v -> ss.insert(pig) )
.chain( v -> ss.createQuery( query )
.setParameter( "n", pig.name )
.getResultList() )
.invoke( list -> {
assertFalse( list.isEmpty() );
assertEquals( 1, list.size() );
assertThatPigsAreEqual( pig, list.get( 0 ) );
} )
.chain( v -> ss.close() ) )
);
}

@Test
public void testTransactionPropagation(VertxTestContext context) {
test( context, getMutinySessionFactory().withStatelessSession(
session -> session.withTransaction( transaction -> session.createSelectionQuery( "from GuineaPig", GuineaPig.class )
.getResultList()
.chain( list -> {
assertNotNull( session.currentTransaction() );
assertFalse( session.currentTransaction().isMarkedForRollback() );
session.currentTransaction().markForRollback();
assertTrue( session.currentTransaction().isMarkedForRollback() );
assertTrue( transaction.isMarkedForRollback() );
return session.withTransaction( t -> {
assertTrue( t.isMarkedForRollback() );
return session.createSelectionQuery( "from GuineaPig", GuineaPig.class ).getResultList();
} );
} ) )
) );
}

@Test
public void testSessionPropagation(VertxTestContext context) {
test( context, getMutinySessionFactory().withStatelessSession(
session -> session.createSelectionQuery( "from GuineaPig", GuineaPig.class ).getResultList()
.chain( list -> getMutinySessionFactory().withStatelessSession( s -> {
assertEquals( session, s );
return s.createSelectionQuery( "from GuineaPig", GuineaPig.class ).getResultList();
} ) )
) );
}

private void assertThatPigsAreEqual( GuineaPig expected, GuineaPig actual) {
assertNotNull( actual );
assertEquals( expected.getId(), actual.getId() );
assertEquals( expected.getName(), actual.getName() );
}

@NamedQuery(name = "findbyname", query = "from GuineaPig where name=:n")
@NamedQuery(name = "updatebyname", query = "update GuineaPig set name='Y'")
@NamedQuery(name = "findall", query = "from GuineaPig")

@Entity(name = "GuineaPig")
@Table(name = "Piggy")
public static class GuineaPig {
@Id
@GeneratedValue
private Integer id;
private String name;
@Version
private int version;

@ManyToOne
private GuineaPig mate;

public GuineaPig() {
}

public GuineaPig(String name) {
this.name = name;
}

public Integer getId() {
return id;
}

public void setId(Integer id) {
this.id = id;
}

public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}

@Override
public String toString() {
return id + ": " + name;
}

@Override
public boolean equals(Object o) {
if ( this == o ) {
return true;
}
if ( o == null || getClass() != o.getClass() ) {
return false;
}
GuineaPig guineaPig = (GuineaPig) o;
return Objects.equals( name, guineaPig.name );
}

@Override
public int hashCode() {
return Objects.hash( name );
}
}
}
Loading