Skip to content

fixes before release #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

fixes before release #2243

merged 1 commit into from
May 1, 2025

Conversation

gavinking
Copy link
Member

  1. fix some more incorrect casts to ReactiveSession or ReactiveSessionImpl
  2. remove the SS.upsert() method taking an entity name (we don't need it)
  3. some minor code cleanups in EntityTypes and CollectionTypes

@gavinking
fixes before release
257ce5c 
1. fix some more incorrect casts to ReactiveSession or ReactiveSessionImpl
2. remove the SS.upsert() method taking an entity name (we don't need it)
3. some minor code cleanups in EntityTypes and CollectionTypes
github-advanced-security[bot]
github-advanced-security bot found potential problems May 1, 2025
View reviewed changes
...rc/main/java/org/hibernate/reactive/engine/spi/ReactiveSharedSessionContractImplementor.java
@@ -22,5 +23,9 @@
return falseFuture();
}

CompletionStage<Object> reactiveImmediateLoad(String entityName, Object id);

CompletionStage<Void> reactiveInitializeCollection(PersistentCollection<?> collection, boolean writing);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'writing' is never used.
@gavinking gavinking merged commit 8f2ab3e into hibernate:main May 1, 2025
18 checks passed
@DavideD DavideD added the 3.0 label May 5, 2025
@DavideD DavideD added this to the 3.0.0.CR1 milestone May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.0
Projects
None yet
Milestone
3.0.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@gavinking @DavideD