Security Details Portfolios data #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bm64
requested review from
pawelfus,
DJTechnoo,
pawellysy and
kamil-musialowski
pawellysy
approved these changes
Nov 29, 2024
DJTechnoo
approved these changes
Nov 29, 2024
kamil-musialowski
approved these changes
Dec 2, 2024
pawelfus
requested changes
Dec 5, 2024
pawelfus
requested changes
Dec 6, 2024
| security: { | ||
| id: 'F0GBR050DD', | ||
| idType: 'MSID' | ||
| } |
There was a problem hiding this comment.
No need to specify type? Here in all other tests? Why the tests pass without it?
pawelfus
requested changes
Dec 11, 2024
| id: 'F0GBR050DD', | ||
| idType: 'MSID' | ||
| }, | ||
| type: 'AssetAllocations' // Specify the type of data to retrieve |
| id: securityId, | ||
| idType: 'ISIN' | ||
| }, | ||
| type: 'AssetAllocations' |
There was a problem hiding this comment.
Wrong API option, demo doesn't work
| for (file of htmlInputFile.files) { | ||
| try { | ||
| fileJSON = JSON.parse(await file.text()); | ||
| if (HighchartsConnectors.Morningstar.isPostmanEnvironmentJSON(fileJSON)) { |
There was a problem hiding this comment.
Wrong path. Should be HighchartsConnectors.Morningstar.Shared.isPostmanEnvironmentJSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add portfolios data converters to security details connector.