Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changelog more readable #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Made changelog more readable #61

wants to merge 1 commit into from

Conversation

DJTechnoo
Copy link
Member

Made changelog readable.

Copy link
Contributor

@kamil-musialowski kamil-musialowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really requested changes since it looks good, but just open questions about the Changelog readability 🤔

Comment on lines 18 to 19
## New Contributors
* @kamil-musialowski made their first contribution in https://github.com/highcharts/connectors-morningstar/pull/50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to leave that section in changelog at all?

Comment on lines +10 to +16
* Fixed failing RNANews test, by @DJTechnoo in https://github.com/highcharts/connectors-morningstar/pull/48
* Adjusted docs titles, by @kamil-musialowski in https://github.com/highcharts/connectors-morningstar/pull/50
* Created manual fetch demo, by @DJTechnoo in https://github.com/highcharts/connectors-morningstar/pull/53
* Corrected URLs, by @bm64 in https://github.com/highcharts/connectors-morningstar/pull/47
* Added security details docs, by @bm64 in https://github.com/highcharts/connectors-morningstar/pull/49
* Added investment screener, by @pawellysy in https://github.com/highcharts/connectors-morningstar/pull/52
* Added Morningstar to HC namespace, by @kamil-musialowski in https://github.com/highcharts/connectors-morningstar/pull/46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to leave those @username?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep them all, but improve them once we get good automation in place

Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants