Skip to content

Commit

Permalink
x86_abi_support: use correct hidden syntax
Browse files Browse the repository at this point in the history
Chromium needs :function hidden and the space between the symbol and the
colon removed, at least for nasm. This matches x86inc.asm.

BUG=webm:1679

Change-Id: Ie47bb75d44d3130791639cbf4e2ebe019e2d686e
  • Loading branch information
Johann committed Mar 31, 2020
1 parent 667138e commit e8be649
Show file tree
Hide file tree
Showing 34 changed files with 142 additions and 142 deletions.
4 changes: 2 additions & 2 deletions vp8/common/x86/dequantize_mmx.asm
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
SECTION .text

;void vp8_dequantize_b_impl_mmx(short *sq, short *dq, short *q)
global sym(vp8_dequantize_b_impl_mmx) PRIVATE
global sym(vp8_dequantize_b_impl_mmx)PRIVATE
sym(vp8_dequantize_b_impl_mmx):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -56,7 +56,7 @@ sym(vp8_dequantize_b_impl_mmx):
;short *dq, 1
;unsigned char *dest, 2
;int stride) 3
global sym(vp8_dequant_idct_add_mmx) PRIVATE
global sym(vp8_dequant_idct_add_mmx)PRIVATE
sym(vp8_dequant_idct_add_mmx):
push rbp
mov rbp, rsp
Expand Down
4 changes: 2 additions & 2 deletions vp8/common/x86/idctllm_mmx.asm
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ SECTION .text

;void vp8_short_idct4x4llm_mmx(short *input, unsigned char *pred,
;int pitch, unsigned char *dest,int stride)
global sym(vp8_short_idct4x4llm_mmx) PRIVATE
global sym(vp8_short_idct4x4llm_mmx)PRIVATE
sym(vp8_short_idct4x4llm_mmx):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -225,7 +225,7 @@ sym(vp8_short_idct4x4llm_mmx):
;int pred_stride,
;unsigned char *dst_ptr,
;int stride)
global sym(vp8_dc_only_idct_add_mmx) PRIVATE
global sym(vp8_dc_only_idct_add_mmx)PRIVATE
sym(vp8_dc_only_idct_add_mmx):
push rbp
mov rbp, rsp
Expand Down
8 changes: 4 additions & 4 deletions vp8/common/x86/idctllm_sse2.asm
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

SECTION .text

global sym(vp8_idct_dequant_0_2x_sse2) PRIVATE
global sym(vp8_idct_dequant_0_2x_sse2)PRIVATE
sym(vp8_idct_dequant_0_2x_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -103,7 +103,7 @@ sym(vp8_idct_dequant_0_2x_sse2):
; unsigned char *dst - 2
; int dst_stride - 3
; )
global sym(vp8_idct_dequant_full_2x_sse2) PRIVATE
global sym(vp8_idct_dequant_full_2x_sse2)PRIVATE
sym(vp8_idct_dequant_full_2x_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -360,7 +360,7 @@ sym(vp8_idct_dequant_full_2x_sse2):
; int dst_stride - 3
; short *dc - 4
; )
global sym(vp8_idct_dequant_dc_0_2x_sse2) PRIVATE
global sym(vp8_idct_dequant_dc_0_2x_sse2)PRIVATE
sym(vp8_idct_dequant_dc_0_2x_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -436,7 +436,7 @@ sym(vp8_idct_dequant_dc_0_2x_sse2):
; int dst_stride - 3
; short *dc - 4
; )
global sym(vp8_idct_dequant_dc_full_2x_sse2) PRIVATE
global sym(vp8_idct_dequant_dc_full_2x_sse2)PRIVATE
sym(vp8_idct_dequant_dc_full_2x_sse2):
push rbp
mov rbp, rsp
Expand Down
2 changes: 1 addition & 1 deletion vp8/common/x86/iwalsh_sse2.asm
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
SECTION .text

;void vp8_short_inv_walsh4x4_sse2(short *input, short *mb_dqcoeff)
global sym(vp8_short_inv_walsh4x4_sse2) PRIVATE
global sym(vp8_short_inv_walsh4x4_sse2)PRIVATE
sym(vp8_short_inv_walsh4x4_sse2):
push rbp
mov rbp, rsp
Expand Down
4 changes: 2 additions & 2 deletions vp8/common/x86/loopfilter_block_sse2_x86_64.asm
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ SECTION .text
; const char *limit,
; const char *thresh
;)
global sym(vp8_loop_filter_bh_y_sse2) PRIVATE
global sym(vp8_loop_filter_bh_y_sse2)PRIVATE
sym(vp8_loop_filter_bh_y_sse2):

%if LIBVPX_YASM_WIN64
Expand Down Expand Up @@ -277,7 +277,7 @@ LF_FILTER xmm0, xmm1, xmm3, xmm8, xmm4, xmm2
; const char *thresh
;)

global sym(vp8_loop_filter_bv_y_sse2) PRIVATE
global sym(vp8_loop_filter_bv_y_sse2)PRIVATE
sym(vp8_loop_filter_bv_y_sse2):

%if LIBVPX_YASM_WIN64
Expand Down
20 changes: 10 additions & 10 deletions vp8/common/x86/loopfilter_sse2.asm
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ SECTION .text
; const char *limit,
; const char *thresh,
;)
global sym(vp8_loop_filter_horizontal_edge_sse2) PRIVATE
global sym(vp8_loop_filter_horizontal_edge_sse2)PRIVATE
sym(vp8_loop_filter_horizontal_edge_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -336,7 +336,7 @@ sym(vp8_loop_filter_horizontal_edge_sse2):
; const char *thresh,
; int count
;)
global sym(vp8_loop_filter_horizontal_edge_uv_sse2) PRIVATE
global sym(vp8_loop_filter_horizontal_edge_uv_sse2)PRIVATE
sym(vp8_loop_filter_horizontal_edge_uv_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -563,7 +563,7 @@ sym(vp8_loop_filter_horizontal_edge_uv_sse2):
; const char *limit,
; const char *thresh,
;)
global sym(vp8_mbloop_filter_horizontal_edge_sse2) PRIVATE
global sym(vp8_mbloop_filter_horizontal_edge_sse2)PRIVATE
sym(vp8_mbloop_filter_horizontal_edge_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -609,7 +609,7 @@ sym(vp8_mbloop_filter_horizontal_edge_sse2):
; const char *thresh,
; unsigned char *v
;)
global sym(vp8_mbloop_filter_horizontal_edge_uv_sse2) PRIVATE
global sym(vp8_mbloop_filter_horizontal_edge_uv_sse2)PRIVATE
sym(vp8_mbloop_filter_horizontal_edge_uv_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -930,7 +930,7 @@ sym(vp8_mbloop_filter_horizontal_edge_uv_sse2):
; const char *limit,
; const char *thresh,
;)
global sym(vp8_loop_filter_vertical_edge_sse2) PRIVATE
global sym(vp8_loop_filter_vertical_edge_sse2)PRIVATE
sym(vp8_loop_filter_vertical_edge_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -995,7 +995,7 @@ sym(vp8_loop_filter_vertical_edge_sse2):
; const char *thresh,
; unsigned char *v
;)
global sym(vp8_loop_filter_vertical_edge_uv_sse2) PRIVATE
global sym(vp8_loop_filter_vertical_edge_uv_sse2)PRIVATE
sym(vp8_loop_filter_vertical_edge_uv_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -1144,7 +1144,7 @@ sym(vp8_loop_filter_vertical_edge_uv_sse2):
; const char *limit,
; const char *thresh,
;)
global sym(vp8_mbloop_filter_vertical_edge_sse2) PRIVATE
global sym(vp8_mbloop_filter_vertical_edge_sse2)PRIVATE
sym(vp8_mbloop_filter_vertical_edge_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -1211,7 +1211,7 @@ sym(vp8_mbloop_filter_vertical_edge_sse2):
; const char *thresh,
; unsigned char *v
;)
global sym(vp8_mbloop_filter_vertical_edge_uv_sse2) PRIVATE
global sym(vp8_mbloop_filter_vertical_edge_uv_sse2)PRIVATE
sym(vp8_mbloop_filter_vertical_edge_uv_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -1271,7 +1271,7 @@ sym(vp8_mbloop_filter_vertical_edge_uv_sse2):
; int src_pixel_step,
; const char *blimit,
;)
global sym(vp8_loop_filter_simple_horizontal_edge_sse2) PRIVATE
global sym(vp8_loop_filter_simple_horizontal_edge_sse2)PRIVATE
sym(vp8_loop_filter_simple_horizontal_edge_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -1376,7 +1376,7 @@ sym(vp8_loop_filter_simple_horizontal_edge_sse2):
; int src_pixel_step,
; const char *blimit,
;)
global sym(vp8_loop_filter_simple_vertical_edge_sse2) PRIVATE
global sym(vp8_loop_filter_simple_vertical_edge_sse2)PRIVATE
sym(vp8_loop_filter_simple_vertical_edge_sse2):
push rbp ; save old base pointer value.
mov rbp, rsp ; set new base pointer value.
Expand Down
6 changes: 3 additions & 3 deletions vp8/common/x86/mfqe_sse2.asm
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ SECTION .text
; int dst_stride,
; int src_weight
;)
global sym(vp8_filter_by_weight16x16_sse2) PRIVATE
global sym(vp8_filter_by_weight16x16_sse2)PRIVATE
sym(vp8_filter_by_weight16x16_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -99,7 +99,7 @@ sym(vp8_filter_by_weight16x16_sse2):
; int dst_stride,
; int src_weight
;)
global sym(vp8_filter_by_weight8x8_sse2) PRIVATE
global sym(vp8_filter_by_weight8x8_sse2)PRIVATE
sym(vp8_filter_by_weight8x8_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -167,7 +167,7 @@ sym(vp8_filter_by_weight8x8_sse2):
; unsigned int *variance, 4
; unsigned int *sad, 5
;)
global sym(vp8_variance_and_sad_16x16_sse2) PRIVATE
global sym(vp8_variance_and_sad_16x16_sse2)PRIVATE
sym(vp8_variance_and_sad_16x16_sse2):
push rbp
mov rbp, rsp
Expand Down
4 changes: 2 additions & 2 deletions vp8/common/x86/recon_mmx.asm
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ SECTION .text
; unsigned char *dst,
; int dst_stride
; )
global sym(vp8_copy_mem8x8_mmx) PRIVATE
global sym(vp8_copy_mem8x8_mmx)PRIVATE
sym(vp8_copy_mem8x8_mmx):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -82,7 +82,7 @@ sym(vp8_copy_mem8x8_mmx):
; unsigned char *dst,
; int dst_stride
; )
global sym(vp8_copy_mem8x4_mmx) PRIVATE
global sym(vp8_copy_mem8x4_mmx)PRIVATE
sym(vp8_copy_mem8x4_mmx):
push rbp
mov rbp, rsp
Expand Down
2 changes: 1 addition & 1 deletion vp8/common/x86/recon_sse2.asm
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ SECTION .text
; unsigned char *dst,
; int dst_stride
; )
global sym(vp8_copy_mem16x16_sse2) PRIVATE
global sym(vp8_copy_mem16x16_sse2)PRIVATE
sym(vp8_copy_mem16x16_sse2):
push rbp
mov rbp, rsp
Expand Down
4 changes: 2 additions & 2 deletions vp8/common/x86/subpixel_mmx.asm
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ SECTION .text
; unsigned int output_width,
; short * vp8_filter
;)
global sym(vp8_filter_block1d_h6_mmx) PRIVATE
global sym(vp8_filter_block1d_h6_mmx)PRIVATE
sym(vp8_filter_block1d_h6_mmx):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -124,7 +124,7 @@ sym(vp8_filter_block1d_h6_mmx):
; unsigned int output_width,
; short * vp8_filter
;)
global sym(vp8_filter_block1dc_v6_mmx) PRIVATE
global sym(vp8_filter_block1dc_v6_mmx)PRIVATE
sym(vp8_filter_block1dc_v6_mmx):
push rbp
mov rbp, rsp
Expand Down
16 changes: 8 additions & 8 deletions vp8/common/x86/subpixel_sse2.asm
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ SECTION .text
; unsigned int output_width,
; short *vp8_filter
;)
global sym(vp8_filter_block1d8_h6_sse2) PRIVATE
global sym(vp8_filter_block1d8_h6_sse2)PRIVATE
sym(vp8_filter_block1d8_h6_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -153,7 +153,7 @@ sym(vp8_filter_block1d8_h6_sse2):
; even number. This function handles 8 pixels in horizontal direction, calculating ONE
; rows each iteration to take advantage of the 128 bits operations.
;*************************************************************************************/
global sym(vp8_filter_block1d16_h6_sse2) PRIVATE
global sym(vp8_filter_block1d16_h6_sse2)PRIVATE
sym(vp8_filter_block1d16_h6_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -333,7 +333,7 @@ sym(vp8_filter_block1d16_h6_sse2):
; Notes: filter_block1d8_v6 applies a 6 tap filter vertically to the input pixels. The
; input pixel array has output_height rows.
;*************************************************************************************/
global sym(vp8_filter_block1d8_v6_sse2) PRIVATE
global sym(vp8_filter_block1d8_v6_sse2)PRIVATE
sym(vp8_filter_block1d8_v6_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -428,7 +428,7 @@ sym(vp8_filter_block1d8_v6_sse2):
; Notes: filter_block1d16_v6 applies a 6 tap filter vertically to the input pixels. The
; input pixel array has output_height rows.
;*************************************************************************************/
global sym(vp8_filter_block1d16_v6_sse2) PRIVATE
global sym(vp8_filter_block1d16_v6_sse2)PRIVATE
sym(vp8_filter_block1d16_v6_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -538,7 +538,7 @@ sym(vp8_filter_block1d16_v6_sse2):
; const short *vp8_filter
;)
; First-pass filter only when yoffset==0
global sym(vp8_filter_block1d8_h6_only_sse2) PRIVATE
global sym(vp8_filter_block1d8_h6_only_sse2)PRIVATE
sym(vp8_filter_block1d8_h6_only_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -651,7 +651,7 @@ sym(vp8_filter_block1d8_h6_only_sse2):
; const short *vp8_filter
;)
; First-pass filter only when yoffset==0
global sym(vp8_filter_block1d16_h6_only_sse2) PRIVATE
global sym(vp8_filter_block1d16_h6_only_sse2)PRIVATE
sym(vp8_filter_block1d16_h6_only_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -816,7 +816,7 @@ sym(vp8_filter_block1d16_h6_only_sse2):
; const short *vp8_filter
;)
; Second-pass filter only when xoffset==0
global sym(vp8_filter_block1d8_v6_only_sse2) PRIVATE
global sym(vp8_filter_block1d8_v6_only_sse2)PRIVATE
sym(vp8_filter_block1d8_v6_only_sse2):
push rbp
mov rbp, rsp
Expand Down Expand Up @@ -908,7 +908,7 @@ sym(vp8_filter_block1d8_v6_only_sse2):
; unsigned int output_height,
; unsigned int output_width
;)
global sym(vp8_unpack_block1d16_h6_sse2) PRIVATE
global sym(vp8_unpack_block1d16_h6_sse2)PRIVATE
sym(vp8_unpack_block1d16_h6_sse2):
push rbp
mov rbp, rsp
Expand Down
Loading

0 comments on commit e8be649

Please sign in to comment.