Skip to content

Commit

Permalink
Revert "domain_conf: Introduce VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE"
Browse files Browse the repository at this point in the history
This breaks vCPU hotplug, because when starting a domain, we
create a copy of domain definition (which becomes live XML) and
during the post parse callbacks we might adjust some tunings so
that vCPU hotplug is possible.

This reverts commit c0f9079.
  • Loading branch information
zippy2 committed Oct 4, 2016
1 parent a88c65e commit ddc8bc1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
6 changes: 0 additions & 6 deletions src/conf/domain_conf.c
Original file line number Diff line number Diff line change
Expand Up @@ -4430,9 +4430,6 @@ virDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
{
int ret;

if (flags & VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE)
return 0;

if (xmlopt->config.devicesPostParseCallback) {
ret = xmlopt->config.devicesPostParseCallback(dev, def, caps, flags,
xmlopt->config.priv,
Expand Down Expand Up @@ -4582,9 +4579,6 @@ virDomainDefPostParse(virDomainDefPtr def,
.parseOpaque = parseOpaque,
};

if (parseFlags & VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE)
return 0;

/* this must be done before the hypervisor-specific callback,
* in case presence of a controller at a specific index is checked
*/
Expand Down
2 changes: 0 additions & 2 deletions src/conf/domain_conf.h
Original file line number Diff line number Diff line change
Expand Up @@ -2647,8 +2647,6 @@ typedef enum {
VIR_DOMAIN_DEF_PARSE_ABI_UPDATE = 1 << 9,
/* skip definition validation checks meant to be executed on define time only */
VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE = 1 << 10,
/* skip post parse callback */
VIR_DOMAIN_DEF_PARSE_SKIP_POST_PARSE = 1 << 11,
} virDomainDefParseFlags;

typedef enum {
Expand Down

0 comments on commit ddc8bc1

Please sign in to comment.