Skip to content

Commit

Permalink
win32: mpv.rc: re-add version info
Browse files Browse the repository at this point in the history
For some reason, the lack of version info was preventing mpv from
appearing in the Default Programs dialog. Re-add it, but don't set the
string version numbers from version.h, because that's what was causing
trouble when the version info was removed. Like the binary version
numbers, these are now hardcoded to 2.0.0.0, which probably doesn't
matter.

The new version info block is also slightly different to the old one. It
fills out all the binary VERSIONINFO fields and makes better use of
macros. It also removes the \000 line terminators from the string
version info, since as far as I can tell, this was just cargo-culting
for an old broken version of the Microsoft resource compiler, and
binutils' windres terminates the strings properly without them.
  • Loading branch information
rossy committed Jul 12, 2016
1 parent 43e811c commit bf2e2bf
Showing 1 changed file with 25 additions and 7 deletions.
32 changes: 25 additions & 7 deletions osdep/mpv.rc
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,31 @@

#include <winver.h>

1 VERSIONINFO
FILEVERSION 2,0,0,0
PRODUCTVERSION 2,0,0,0
FILEOS VOS__WINDOWS32
FILETYPE VFT_APP
{
}
VS_VERSION_INFO VERSIONINFO
FILEVERSION 2, 0, 0, 0
PRODUCTVERSION 2, 0, 0, 0
FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
FILEFLAGS 0
FILEOS VOS__WINDOWS32
FILETYPE VFT_APP
FILESUBTYPE 0
{
BLOCK "StringFileInfo" {
BLOCK "000004b0" {
VALUE "Comments", "mpv is distributed under the terms of the GNU General Public License Version 2 or later."
VALUE "CompanyName", "mpv"
VALUE "FileDescription", "mpv"
VALUE "FileVersion", "2.0.0.0"
VALUE "LegalCopyright", "(C) 2000-2016 mpv/mplayer2/MPlayer"
VALUE "OriginalFilename", "mpv.exe"
VALUE "ProductName", "mpv"
VALUE "ProductVersion", "2.0.0.0"
}
}
BLOCK "VarFileInfo" {
VALUE "Translation", 0, 1200
}
}

IDI_ICON1 ICON DISCARDABLE "etc/mpv-icon.ico"

Expand Down

0 comments on commit bf2e2bf

Please sign in to comment.