Skip to content

Commit

Permalink
GDK W32: Support switching IM contexts at runtime
Browse files Browse the repository at this point in the history
This leverages the normal input context switching mechanism in GTK
by making it think that the gtk-im-module setting changed.
The backend returns gtk-im-module value as "ime" if W32
IME API says that an IME is in use. Otherwise it returns
and empty string - this still triggers an input context
switching code, which, not being able to create the desired context
(which is and empty string), falls back to looking at current
keyboard layout (currently that code is still a FIXME).

Paired with the code that signals gtk-im-module change on keyboard layout
switches, this is sufficient to make GTK capable of switching to
the appropriate IM context at runtime. At least, the kinds of context
that specify languages for which they are used automatically by default
(once locale matching is implemented), and the IME context.

Loading other kinds of IM context might still work via specifying
the gtk-im-module setting in gtk ini file, but doing so will likely
make GTK incapable of using the IME context that is used
for Korean, Chinese and Japanese (and some other languages).

Until someone figures out a way to actually change gtk-im-module
setting on Windows at runtime with meaningful values, the behaviour
introduced by this commit seems like a sufficient workaround.
  • Loading branch information
LRN committed Oct 6, 2018
1 parent 0657a53 commit 66c0336
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions gdk/win32/gdkevents-win32.c
Original file line number Diff line number Diff line change
Expand Up @@ -2124,6 +2124,7 @@ gdk_event_translate (MSG *msg,
(gulong) msg->wParam,
(gpointer) msg->lParam, _gdk_input_locale_is_ime ? " (IME)" : "",
_gdk_input_codepage));
gdk_display_setting_changed (display, "gtk-im-module");
break;

case WM_SYSKEYUP:
Expand Down
9 changes: 9 additions & 0 deletions gdk/win32/gdkproperty-win32.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,15 @@ _gdk_win32_get_setting (const gchar *name,
}
}
}
else if (strcmp ("gtk-im-module", name) == 0)
{
if (_gdk_input_locale_is_ime)
g_value_set_string (value, "ime");
else
g_value_set_string (value, "");

return TRUE;
}

return FALSE;
}

0 comments on commit 66c0336

Please sign in to comment.