Turn on warning when func take time to compile

hoangatuan · Mar 4, 2024 · 3ed7043 · 3ed7043
1 parent 6efb411
commit 3ed7043
Show file tree

Hide file tree

Showing 31 changed files with 1,481 additions and 32 deletions.
diff --git a/Core/CommonUI/Package.swift b/Core/CommonUI/Package.swift
@@ -34,3 +34,12 @@ let package = Package(
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}
diff --git a/Features/Movies/Package.swift b/Features/Movies/Package.swift
@@ -41,8 +41,17 @@ let package = Package(
                 .product(name: "NetworkMock", package: "Network"),
             ],
             resources: [
-                .process("Resources")
+                .process("Resources"),
             ]
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}
diff --git a/Features/Movies/Sources/Movies/Coordinator/MoviesCoordinator.swift b/Features/Movies/Sources/Movies/Coordinator/MoviesCoordinator.swift
@@ -23,7 +23,7 @@ enum MovieSheetDesination: Identifiable {
             return "share"
         }
     }
-    
+
     case share(movie: Movie)
 }
 
@@ -34,7 +34,6 @@ enum Destination: Hashable {
 }
 
 public struct MoviesCoordinator: View {
-
     @EnvironmentObject private var router: Router
     private let dependencies: Dependencies
 
@@ -51,7 +50,8 @@ public struct MoviesCoordinator: View {
             case let .movieByGenre(genre):
                 GenreMoviesView(dependencies: .init(
                     genre: genre,
-                    repository: MovieRepository(apiClientService: dependencies.apiClient))
+                    repository: MovieRepository(apiClientService: dependencies.apiClient)
+                )
                 )
             case let .movieDetail(movie):
                 MovieDetailView(
@@ -68,7 +68,7 @@ public struct MoviesCoordinator: View {
         .sheet(item: $router.presentedSheet) { destination in
             if let destination = destination.destination as? MovieSheetDesination {
                 switch destination {
-                case .share(movie: let movie):
+                case .share(movie: _):
                     Text("Share movie")
                 }
             }

diff --git a/Features/People/Package.swift b/Features/People/Package.swift
@@ -32,6 +32,11 @@ let package = Package(
                 .product(name: "DomainData", package: "Domain"),
                 "Router",
                 "DesignSystem",
+            ],
+            swiftSettings: [
+                .unsafeFlags([
+                    "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+                ]),
             ]
         ),
         .testTarget(
@@ -41,8 +46,17 @@ let package = Package(
                 .product(name: "NetworkMock", package: "Network"),
             ],
             resources: [
-                .process("Resources")
+                .process("Resources"),
             ]
         ),
     ]
 )
+
+// for target in package.targets {
+//    target.swiftSettings = target.swiftSettings ?? []
+//    target.swiftSettings?.append(
+//        .unsafeFlags([
+//            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200"
+//        ])
+//    )
+// }
diff --git a/Features/People/Sources/People/Coordinator/PeopleCoordinator.swift b/Features/People/Sources/People/Coordinator/PeopleCoordinator.swift
@@ -1,15 +1,15 @@
 //
-//  SwiftUIView.swift
-//  
+//  PeopleCoordinator.swift
+//
 //
 //  Created by Tuan Hoang on 19/11/23.
 //
 
-import SwiftUI
 import Domain
 import DomainData
 import Network
 import Router
+import SwiftUI
 
 public enum PublicPeopleDestination: Hashable {
     case movieDetail(movie: Movie)
@@ -23,19 +23,18 @@ enum SheetDesination: Identifiable {
             return "share"
         }
     }
-    
+
     case share(person: PersonDetail)
 }
 
 public struct PersonDetailCoordinator: View {
-
     @EnvironmentObject private var router: Router
     private let dependencies: Dependencies
 
     public init(dependencies: Dependencies) {
         self.dependencies = dependencies
     }
-    
+
     public var body: some View {
         PersonDetailView(
             dependencies: .init(personId: dependencies.personId, peopleRepository: PeopleRepository(apiClientService: dependencies.apiClient))
@@ -44,7 +43,7 @@ public struct PersonDetailCoordinator: View {
         .sheet(item: $router.presentedSheet) { destination in
             if let destination = destination.destination as? SheetDesination {
                 switch destination {
-                case .share(person: let person):
+                case .share(person: _):
                     Text("Share person")
                 }
             }
@@ -56,7 +55,7 @@ public extension PersonDetailCoordinator {
     struct Dependencies {
         let personId: Int
         let apiClient: IAPIClientService
-        
+
         public init(personId: Int, apiClient: IAPIClientService) {
             self.personId = personId
             self.apiClient = apiClient

diff --git a/Features/Search/Package.swift b/Features/Search/Package.swift
@@ -39,10 +39,16 @@ let package = Package(
             dependencies: [
                 "Search",
                 .product(name: "NetworkMock", package: "Network"),
-            ],
-            resources: [
-                .process("Resources")
             ]
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}
diff --git a/Features/TVSeries/Package.swift b/Features/TVSeries/Package.swift
@@ -41,8 +41,17 @@ let package = Package(
                 .product(name: "NetworkMock", package: "Network"),
             ],
             resources: [
-                .process("Resources")
+                .process("Resources"),
             ]
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}
diff --git a/Features/TVSeries/Sources/TVSeries/Coordinator/TVSeriesCoordinator.swift b/Features/TVSeries/Sources/TVSeries/Coordinator/TVSeriesCoordinator.swift
@@ -28,13 +28,13 @@ public struct TVSeriesCoordinator: View {
 
     public var body: some View {
         TVSeriesHomeView(repository: TVSeriesRepository(apiClientService: dependencies.apiClient))
-        .navigationDestination(for: Destination.self) { destination in
-            switch destination {
-            case .tvSeriesDetail(let tvSeries):
-                Text("TV Series")
-                    .toolbar(.hidden, for: .tabBar)
+            .navigationDestination(for: Destination.self) { destination in
+                switch destination {
+                case .tvSeriesDetail:
+                    Text("TV Series")
+                        .toolbar(.hidden, for: .tabBar)
+                }
             }
-        }
     }
 }
 

diff --git a/Foundation/DesignSystem/Package.swift b/Foundation/DesignSystem/Package.swift
@@ -24,3 +24,12 @@ let package = Package(
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}
diff --git a/Foundation/DesignSystem/Sources/DesignSystem/Color.swift b/Foundation/DesignSystem/Sources/DesignSystem/Color.swift
@@ -19,7 +19,7 @@ public extension Color {
 
 extension Color {
     init?(hex: String) {
-        var hexSanitized = hex.trimmingCharacters(in: .whitespacesAndNewlines)
+        var hexSanitized: String = hex.trimmingCharacters(in: .whitespacesAndNewlines)
         hexSanitized = hexSanitized.replacingOccurrences(of: "#", with: "")
 
         var rgb: UInt64 = 0

diff --git a/Foundation/Domain/Package.swift b/Foundation/Domain/Package.swift
@@ -20,15 +20,15 @@ let package = Package(
     ],
     dependencies: [
         .package(path: "./Network"),
-        .package(path: "./HelperMacros")
+        .package(path: "./HelperMacros"),
     ],
     targets: [
         // Targets are the basic building blocks of a package, defining a module or a test suite.
         // Targets can depend on other targets in this package and products from dependencies.
         .target(
             name: "Domain",
             dependencies: [
-                "HelperMacros"
+                "HelperMacros",
             ]
         ),
         .target(
@@ -44,3 +44,12 @@ let package = Package(
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}
diff --git a/Foundation/HelperMacros/Package.swift b/Foundation/HelperMacros/Package.swift
@@ -1,8 +1,8 @@
 // swift-tools-version: 5.9
 // The swift-tools-version declares the minimum version of Swift required to build this package.
 
-import PackageDescription
 import CompilerPluginSupport
+import PackageDescription
 
 let package = Package(
     name: "HelperMacros",
@@ -30,7 +30,7 @@ let package = Package(
             name: "HelperMacrosMacros",
             dependencies: [
                 .product(name: "SwiftSyntaxMacros", package: "swift-syntax"),
-                .product(name: "SwiftCompilerPlugin", package: "swift-syntax")
+                .product(name: "SwiftCompilerPlugin", package: "swift-syntax"),
             ]
         ),
 
@@ -50,3 +50,12 @@ let package = Package(
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}
diff --git a/Foundation/Logger/Package.swift b/Foundation/Logger/Package.swift
@@ -28,3 +28,12 @@ let package = Package(
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}
diff --git a/Foundation/Network/Package.swift b/Foundation/Network/Package.swift
@@ -33,15 +33,24 @@ let package = Package(
             name: "NetworkMock",
             dependencies: [
                 "Network",
-                .product(name: "OHHTTPStubsSwift", package: "OHHTTPStubs")
+                .product(name: "OHHTTPStubsSwift", package: "OHHTTPStubs"),
             ]
         ),
         .testTarget(
             name: "NetworkTests",
             dependencies: [
                 "Network",
-                .product(name: "OHHTTPStubsSwift", package: "OHHTTPStubs")
+                .product(name: "OHHTTPStubsSwift", package: "OHHTTPStubs"),
             ]
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}
diff --git a/Foundation/Router/Package.swift b/Foundation/Router/Package.swift
@@ -24,3 +24,12 @@ let package = Package(
         ),
     ]
 )
+
+for target in package.targets {
+    target.swiftSettings = target.swiftSettings ?? []
+    target.swiftSettings?.append(
+        .unsafeFlags([
+            "-Xfrontend", "-warn-long-function-bodies=200", "-Xfrontend", "-warn-long-expression-type-checking=200",
+        ])
+    )
+}