Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed HTML to fix error message #5

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Renamed HTML to fix error message #5

merged 1 commit into from
Aug 29, 2018

Conversation

jbednar
Copy link
Member

@jbednar jbednar commented Aug 29, 2018

The HTML object didn't follow the naming convention of the other Panel objects, and the PanelBase error message stripped off the last 5 characters of the class name when reporting issues, leaving this name with nothing in it. Renamed to HTMLPanel to match the other objects, so that the error message correctly reports that it expects HTML objects.

@jbednar jbednar requested a review from philippjfr August 29, 2018 00:02
@philippjfr philippjfr merged commit b01b669 into master Aug 29, 2018
@philippjfr philippjfr deleted the html branch September 4, 2018 03:15
@ahuang11 ahuang11 mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants