-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HoloViews.layout issue #6063
base: main
Are you sure you want to change the base?
Conversation
panel/tests/pane/test_holoviews.py
Outdated
plot = pn.bind(_plot, widget) | ||
|
||
@hv_available | ||
def test_holoviews_layout_objects(document, comm): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the below test cases. Thanks.
If you agree that the layout should not contain the widget_layout
when its empty. Then we should try to find fix.
The alternative would be to set visible=False
dynamically on the widget_layout
when it contains no objects.
If you know where the fix should be applied I would appreciate you tell me or implement the fix. I have spent some time without being able to identify the place. Thanks.
UPDATE: LOOKING AT THE HoloViews implementation I can see that I can't expect the widget layout to be in position 1. But I still need to know whether the layout objects should be updated or the widget_layout
invisible.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6063 +/- ##
===========================================
- Coverage 84.62% 40.64% -43.99%
===========================================
Files 295 295
Lines 43976 43983 +7
===========================================
- Hits 37215 17877 -19338
- Misses 6761 26106 +19345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This still needs your input @philippjfr |
Fixes
HoloViews.layout
issue described in #5628 (comment), i.e. that thewidget_layout
is shown when it holds no widgets.Todo.