Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending and receiving of events from ESM components #7257

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 11, 2024

The handling of sending and receiving of events on ESM components had some glaring holes, which are fixed here.

  • Add tests
  • Add docs

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.25%. Comparing base (2b0b90e) to head (f5173aa).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
panel/custom.py 80.00% 4 Missing ⚠️
panel/tests/ui/test_custom.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7257      +/-   ##
==========================================
+ Coverage   82.23%   82.25%   +0.01%     
==========================================
  Files         337      337              
  Lines       50258    50293      +35     
==========================================
+ Hits        41332    41366      +34     
- Misses       8926     8927       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit c63e06e into main Sep 11, 2024
16 checks passed
@philippjfr philippjfr deleted the esm_event_fixes branch September 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant