More improvements for loading notebook extension #7274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there were more problems with the notebook load script. Specifically if you got into a failed loading state, there was no way to recover because
root._bokeh_is_loading
would still be non-zero, indicating that initialization was still in process and should therefore be skipped. We also now do not override the existing timeout, fix the error handling when a resource is unavailable, reset the timeout when we re-attempt loading Bokeh. Lastly we avoid loading Bokeh and Panel twice if HoloViews is imported.