Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More improvements for loading notebook extension #7274

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

philippjfr
Copy link
Member

Turns out there were more problems with the notebook load script. Specifically if you got into a failed loading state, there was no way to recover because root._bokeh_is_loading would still be non-zero, indicating that initialization was still in process and should therefore be skipped. We also now do not override the existing timeout, fix the error handling when a resource is unavailable, reset the timeout when we re-attempt loading Bokeh. Lastly we avoid loading Bokeh and Panel twice if HoloViews is imported.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.19%. Comparing base (d5070c9) to head (97d45df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/config.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7274   +/-   ##
=======================================
  Coverage   82.18%   82.19%           
=======================================
  Files         337      337           
  Lines       50364    50363    -1     
=======================================
+ Hits        41392    41394    +2     
+ Misses       8972     8969    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit f407a0b into main Sep 13, 2024
16 checks passed
@philippjfr philippjfr deleted the nb_load_fixes branch September 13, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant