-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version extraction for APsystems #138023
Conversation
Fixed index out of range error when inverter version number is returned empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @mawoka-myblock, @SonnenladenGmbH, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Wouldn't it be easier to use the get method on the array? |
@home-assistant rename Fix version extraction for APsystems |
I can confirm that this fix works for me. Thanks. |
Updated logic to ensure sw_version is set to None instead of returning "Unknown" when the device version is unavailable, as per review feedback.
Co-authored-by: Marlon <[email protected]>
@alfwro13 Please don't do merges here. Follow this guide instead: https://developers.home-assistant.io/docs/development_catching_up/ |
Reformated for better visualization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @alfwro13 👍
../Frenck
You see, you manged it @alfwro13! |
Co-authored-by: Marlon <[email protected]>
Fixed index out of range error when inverter version number is returned empty
Proposed change
This fixes the index out of range error message when the device version number is missing - Issue #137552
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: