Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings -> Automations: show a title for "State" column #23977

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ildar170975
Copy link
Contributor

Breaking change

Proposed change

The "State" column was already defined as "sortable" - but it did not have a title displayed.
After the fix:

изображение

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ildar170975 ildar170975 marked this pull request as ready for review January 31, 2025 04:35
@piitaya
Copy link
Member

piitaya commented Jan 31, 2025

Hi 👋

I'm not sure adding a title will help to better understand the toggle. State is too technical for this.

Did you add it to better explain the toggle or to be able to sort the items?

@ildar170975
Copy link
Contributor Author

ildar170975 commented Jan 31, 2025

Sometimes it is needed to see which automations are ON, which are OFF.
Currently we can use a sort here:

изображение

This is good, but there is no header for this column.
And for a beginner it could be unclear what this "State" means.
Also, it is inconsistency that we allow to sort by some column with a button - but do not allow to sort with a header.

State is too technical for this.

Agree, but this word is already used...
Suggestion:

  1. We accept this PR.
  2. We change an English (and then for other languages) label - it will be "Enabled" (or someone may propose a different word). OR I can edit "en.json" within this PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants