v-for should add unique key; fix Disqus same comments showing up on m…

…ultiple pages
hongmaoxiao · Feb 9, 2018 · fe42913 · fe42913
1 parent 120a17b
commit fe42913
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/app/components/articles.vue b/app/components/articles.vue
@@ -4,7 +4,7 @@
     <Loading v-if="loading" />
     <section class="articles-wrapper items" v-title v-show="!loading">
       <ul class="articles">
-        <li v-for="article in articles">
+        <li v-for="article in articles" :key="article.ID">
           <router-link :to="{ name: 'article', params: {id: article.ID} }">{{article.Title}}</router-link>
         </li>
       </ul>

diff --git a/app/components/single.vue b/app/components/single.vue
@@ -34,8 +34,7 @@
       "$route": "fetchData",
     },
     created() {
-      this.page_id = `article/${this.$route.params.id}`;
-      this.url = window.location.href;
+      this.page_id = `${window.location.origin}#!${this.$route.params.id}`;
       this.fetchData();
     },
     methods: {
@@ -74,7 +73,7 @@
       </div>
     </section>
     <div class="comments" v-show="!loading">
-      <vue-disqus shortname="fengxiaomao" :identifier="page_id" :url="url"></vue-disqus>
+      <vue-disqus shortname="fengxiaomao" :identifier="page_id" :url="page_id"></vue-disqus>
     </div>
     <Foot v-show="!loading" />
   </section>