Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsr): exclude unused markdown files #3767

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Dec 24, 2024

These may have been included because they could not be linked to files on GitHub before on JSR, but now they are linked correctly like npm. Therefore, it is better to exclude them.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (4eb101d) to head (4d4315a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3767   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         159      159           
  Lines       10178    10178           
  Branches     2896     2857   -39     
=======================================
  Hits         9336     9336           
  Misses        841      841           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Hi @ryuapp

Nice! Looks good to me.

@yusukebe yusukebe merged commit 7751ff3 into honojs:main Dec 25, 2024
16 checks passed
@ryuapp ryuapp deleted the fix-jsr-unused-markdown-file branch December 25, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants