Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compose): follow up #3932 #3934

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Feb 19, 2025

This is a follow-up to PR #3922.

Fixed jsdoc and made minor type definition changes.
Marked as chore since it does not constitute a change to the internal structure.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@EdamAme-x
Copy link
Contributor Author

EdamAme-x commented Feb 19, 2025

@EdamAme-x
Copy link
Contributor Author

This seems to be a bug caused by a spec change in 2.2.0, as it works fine when Deno is reverted to 2.1.10 (one version earlier).

https://github.com/denoland/deno/releases/tag/v2.2.0

@EdamAme-x
Copy link
Contributor Author

EdamAme-x commented Feb 19, 2025

@yusukebe
Copy link
Member

Yes. Updating to TypeScript v5.7 caused this error. I'm investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants