feat(context): Introduce ContextVariableMap. #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usualoma
force-pushed
the
feat-context-variable-map
branch
from
c30b87f to
e46c2c1
Compare
usualoma
force-pushed
the
feat-context-variable-map
branch
from
e46c2c1 to
a5d4d3b
Compare
Closed
RichiCoder1
reviewed
Jul 28, 2022
| @@ -7,6 +7,8 @@ import { METHOD_NAME_ALL, METHOD_NAME_ALL_LOWERCASE } from './router' | |||
| import { TrieRouter } from './router/trie-router' // Default Router | |||
| import { getPathFromURL, mergePath } from './utils/url' | |||
|
|
|||
| export interface ContextVariableMap {} | |||
There was a problem hiding this comment.
I forget the specifics, but this should probably extend Record<string, any>
There was a problem hiding this comment.
In this PR, there is no need to extend Record<string, any> since ContextVariableMap is a type for type definition and no object is created. (This is like HTMLElementTagNameMap.)
Also, not extending Record<string, any> will give better completion results.
src/context.ts
Outdated
| @@ -20,7 +20,10 @@ export interface Context<RequestParamKeyType extends string = string, E = Env> { | |||
| header: (name: string, value: string) => void | |||
| status: (status: StatusCode) => void | |||
| set: (key: string, value: any) => void | |||
There was a problem hiding this comment.
Set should probably also attempt to enforce the type of value if it's specified on ContextVariableMap for extra type safety.
There was a problem hiding this comment.
Thanks!
Fixed in 1852968.
usualoma
changed the title
|
Thank you! Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to type the value of
ctx.set('variable', var)orctx.get('variable').This is one of the ideas to solve the #414 problem, but even if this were not used to solve #414, I think this would still be a useful feature.