Skip to content

Commit

Permalink
[SPARK-17486] Remove unused TaskMetricsUIData.updatedBlockStatuses field
Browse files Browse the repository at this point in the history
The `TaskMetricsUIData.updatedBlockStatuses` field is assigned to but never read, increasing the memory consumption of the web UI. We should remove this field.

Author: Josh Rosen <[email protected]>

Closes apache#15038 from JoshRosen/remove-updated-block-statuses-from-TaskMetricsUIData.
  • Loading branch information
JoshRosen authored and zsxwing committed Sep 12, 2016
1 parent 767d480 commit 72eec70
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions core/src/main/scala/org/apache/spark/ui/jobs/UIData.scala
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import scala.collection.mutable.{HashMap, LinkedHashMap}
import org.apache.spark.JobExecutionStatus
import org.apache.spark.executor.{ShuffleReadMetrics, ShuffleWriteMetrics, TaskMetrics}
import org.apache.spark.scheduler.{AccumulableInfo, TaskInfo}
import org.apache.spark.storage.{BlockId, BlockStatus}
import org.apache.spark.util.AccumulatorContext
import org.apache.spark.util.collection.OpenHashSet

Expand Down Expand Up @@ -145,7 +144,6 @@ private[spark] object UIData {
memoryBytesSpilled = m.memoryBytesSpilled,
diskBytesSpilled = m.diskBytesSpilled,
peakExecutionMemory = m.peakExecutionMemory,
updatedBlockStatuses = m.updatedBlockStatuses.toList,
inputMetrics = InputMetricsUIData(m.inputMetrics.bytesRead, m.inputMetrics.recordsRead),
outputMetrics =
OutputMetricsUIData(m.outputMetrics.bytesWritten, m.outputMetrics.recordsWritten),
Expand Down Expand Up @@ -193,7 +191,6 @@ private[spark] object UIData {
memoryBytesSpilled: Long,
diskBytesSpilled: Long,
peakExecutionMemory: Long,
updatedBlockStatuses: Seq[(BlockId, BlockStatus)],
inputMetrics: InputMetricsUIData,
outputMetrics: OutputMetricsUIData,
shuffleReadMetrics: ShuffleReadMetricsUIData,
Expand Down

0 comments on commit 72eec70

Please sign in to comment.