feat: new container types #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouarin
force-pushed
the
new-container
branch
4 times, most recently
from
9b30fea to
f76a83b
Compare
gouarin
force-pushed
the
new-container
branch
from
722464a to
df9f1f8
Compare
pmatalon
force-pushed
the
new-container
branch
from
4517f56 to
78f74d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the possibility to change the container used to store the values of a field. Two types of container are available for now:
It's also possible to change the memory layout (row major or column major). There are still various bugs in Eigen due to some incompatibilities between row major and column major when we pass from a vector to a scalar. This is often the case when using the views and the lazy evaluation. This issue should be investigated in a future work.
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct