Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve benchmark_search #250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sbstndb
Copy link

@sbstndb sbstndb commented Dec 17, 2024

-	The new samurai::find() requires a xt::xtensor_fixed instead of a std::array
-	This modification allows the benchmark to compile and run successfully
  • I have installed pre-commit locally and use it to validate my commits.
  • The PR title follows the conventional commits convention.
    Available tags: 'build', 'chore', 'ci', 'docs', 'feat', 'fix', 'perf', 'refactor', 'revert', 'style', 'test'
  • This new PR is documented.
  • This new PR is tested.

Description

The file benchmark_search.cpp is no longer up to date. It requires a modification according to a change in algorithm.hpp here : bc93fef#diff-e48e062924e95ca5a9ca5d59cfd9844509d6c8152a986cc8c304f0c7a030dd47L250

Related issue

Previously, the benchmark doesn't compile due to the following error :

error: no matching function for call to ‘find(samurai::CellArray<1, samurai::Interval<int, long long int>, 20>::lca_type&, std::array<int, 1>&)’

How has this been tested?

The benchmark have been run with coherent results with GCC@14 and LLVM@16

Code of Conduct

By submitting this PR, you agree to follow our Code of Conduct

  • I agree to follow this project's Code of Conduct

	-	The new samurai::find() requires a xt::xtensor_fixed instead of a std::array
	-	This modification allows the benchmark to compile and run successfully
@sbstndb sbstndb changed the title fix : Resolve benchmark_search fix: Resolve benchmark_search Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant