make pylint happier: format => file_format #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format() is a built-in Python function. Rename parameter to avoid local overwrite. This will also avoid complaints from pylint when run on this file, or on code that derives from the Dataset class.
strani
requested changes
Sep 22, 2018
There was a problem hiding this comment.
format is used as a parameter not only in the Dataset class but also in the model file (RTEnsemble). Since I think you are right about making code complaints with pylint, I would suggest you modify accordingly the rest of the project. Please take care also of test cases using this keyword parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format() is a built-in Python function.
Rename parameter to avoid local overwrite.
This will also avoid complaints from pylint when run on this file, or on code that derives from the Dataset class.