Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8608 - Adjust Feedback/ Contact form #3552

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

NFriedo
Copy link
Contributor

@NFriedo NFriedo commented Jan 9, 2025

Description

SVS contact form

  • adapt text and options
  • replace support mail adresses for nbc

Links to Tickets or other pull requests

BC-8608
hpi-schul-cloud/dof_app_deploy#1080

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@hoeppner-dataport hoeppner-dataport merged commit 9eaae97 into main Jan 10, 2025
69 of 70 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-8608-adjust-contact-form branch January 10, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants