Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger improvements #735

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Fishrock123
Copy link
Member

Some minor follow-up for my previous change to the logger which made it use the debug formatter. Very helpful for debugging but probably annoying in "production-like" logs.

This also does some code deduplication.

I'd like to clean this up more but that probably means investing time in either changing the log format entirely or separating out the key-value formatter from log so that we can call it separately before passing to a log level.

Should help clean up stuff in the release-mode json logs.
Ideally there would be a separate key-value formatter that isn't directly connected to the log crate.
@Fishrock123
Copy link
Member Author

error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download for channel nightly
Sometimes not all components are available in any given nightly.
Error: Process completed with exit code 1.

Well that's fun. Maybe we should run fmt and clippy on beta and not nightly.

@tirr-c
Copy link
Collaborator

tirr-c commented Nov 5, 2020

Well rustfmt is broken for over a week according to rust-toolstate, I haven't seen this before. Maybe we really need beta?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants