Skip to content

[tests] chore: rename lora model-level tests. #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented May 2, 2025

What does this PR do?

Just renames model-level LoRA tests so that they get picked up in our PR CI:

python -m pytest -n 4 --max-worker-restart=0 --dist=loadfile \
-s -v \
--make-reports=tests_models_lora_peft_main \
tests/models/ -k "lora"

@sayakpaul sayakpaul requested a review from DN6 May 2, 2025 14:55
@sayakpaul
Copy link
Member Author

The failing test passes locally for me. Quite possibly flaky.

Copy link
Contributor

github-actions bot commented Jun 2, 2025

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Jun 2, 2025
@sayakpaul sayakpaul removed the stale Issues that haven't received updates label Jun 2, 2025
@sayakpaul sayakpaul merged commit 20273e5 into main Jun 2, 2025
29 checks passed
@sayakpaul sayakpaul deleted the fix-lora-model-test-names branch June 2, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant