Markdown Refinements & Installation Streamlining for a Smooth User Journey #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
philschmid
reviewed
Jun 30, 2023
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "If you are going to use Sagemaker in a local environment. You need access to an IAM Role with the required permissions for Sagemaker. You can find [here](https://docs.aws.amazon.com/sagemaker/latest/dg/sagemaker-roles.html) more about it.\n", | ||
| "\n" | ||
| "### Configure IAM\n", |
There was a problem hiding this comment.
not a fan of to many headlines is not fitting the other styles
There was a problem hiding this comment.
Can you remove the many headlines?
|
Hey Phil -- apologies for the complexity. Yeah, it's mainly just to prevent others from running into the same issue in SageMaker Studio Notebooks that I ran into. (Studio Notebooks is recommended in the blog post.) I refined some grammar, etc while I was at it. |
philschmid
reviewed
Jul 13, 2023
| @@ -122,7 +165,7 @@ | |||
| "\n", | |||
| "model_id=\"bigscience/bloomz-7b1\"\n", | |||
| "\n", | |||
| "# Load tokenizer of BLOOMZ\n", | |||
philschmid
reviewed
Jul 13, 2023
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "To train our model, we need to convert our inputs (text) to token IDs. This is done by a 🤗 Transformers Tokenizer. If you are not sure what this means, check out **[chapter 6](https://huggingface.co/course/chapter6/1?fw=tf)** of the Hugging Face Course." | ||
| "### Tokenize Dataset \n", |
philschmid
reviewed
Jul 13, 2023
Comment on lines
303
to
+308
| "import time\n", | ||
| "# define Training Job Name \n", | ||
| "job_name = f'huggingface-peft-{time.strftime(\"%Y-%m-%d-%H-%M-%S\", time.localtime())}'\n", | ||
| "\n", | ||
| "from sagemaker.huggingface import HuggingFace\n", | ||
| "# Set up our training job name using a timestamp to ensure it's unique\n", | ||
| "job_name = f'huggingface-peft-{time.strftime(\"%Y-%m-%d-%H-%M-%S\", time.localtime())}'\n", | ||
| "\n", | ||
| "# hyperparameters, which are passed into the training job\n", | ||
| "from sagemaker.huggingface import HuggingFace" |
There was a problem hiding this comment.
why did you change the order?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I had issues following the notebook until I realized I wasn't using the write SageMaker image and I did the
pip installof the requirements.txt too late in the process.While I was at it, I edited the other explanations in the markdown, some error handling towards the beginning, and changed
!pip installto%pip installbecause this seems to be the recommended approach.@philschmid