Revoke JobConfigurationChangedProcessEngine code (apache#29736)

hunkier · Jan 16, 2024 · 4ad497a · 4ad497a
1 parent 0eef118
commit 4ad497a
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/...ta/pipeline/core/metadata/node/config/processor/JobConfigurationChangedProcessEngine.java b/...ta/pipeline/core/metadata/node/config/processor/JobConfigurationChangedProcessEngine.java
@@ -29,6 +29,8 @@
 import org.apache.shardingsphere.elasticjob.lite.api.bootstrap.impl.OneOffJobBootstrap;
 import org.apache.shardingsphere.mode.event.DataChangedEvent.Type;
 
+import java.util.Collection;
+
 /**
  * Job configuration changed process engine.
  */
@@ -47,8 +49,10 @@ public final class JobConfigurationChangedProcessEngine {
     public <T extends PipelineJobConfiguration> void process(final Type eventType, final JobConfiguration jobConfig, final JobConfigurationChangedProcessor<T> processor) {
         String jobId = jobConfig.getJobName();
         if (jobConfig.isDisabled()) {
+            // Get sharding items before stop job, because sharding items will be cleared after stop job.
+            Collection<Integer> shardingItems = PipelineJobRegistry.getShardingItems(jobId);
             PipelineJobRegistry.stop(jobId);
-            disableJob(jobId);
+            disableJob(jobId, shardingItems);
             return;
         }
         switch (eventType) {
@@ -70,9 +74,9 @@ public <T extends PipelineJobConfiguration> void process(final Type eventType, f
         }
     }
 
-    private void disableJob(final String jobId) {
+    private void disableJob(final String jobId, final Collection<Integer> shardingItems) {
         PipelineDistributedBarrier distributedBarrier = PipelineDistributedBarrier.getInstance(PipelineJobIdUtils.parseContextKey(jobId));
-        for (Integer each : PipelineJobRegistry.getShardingItems(jobId)) {
+        for (Integer each : shardingItems) {
             distributedBarrier.persistEphemeralChildrenNode(PipelineMetaDataNode.getJobBarrierDisablePath(jobId), each);
         }
     }