Fix target in BindValidationFailureAnalyzer

See spring-projectsgh-40035
hyk001 · Apr 16, 2024 · 201885a · 201885a
1 parent 3b98056
commit 201885a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/...ain/java/org/springframework/boot/diagnostics/analyzer/BindValidationFailureAnalyzer.java b/...ain/java/org/springframework/boot/diagnostics/analyzer/BindValidationFailureAnalyzer.java
@@ -47,9 +47,9 @@ protected FailureAnalysis analyze(Throwable rootFailure, Throwable cause) {
 	private ExceptionDetails getBindValidationExceptionDetails(Throwable rootFailure) {
 		BindValidationException validationException = findCause(rootFailure, BindValidationException.class);
 		if (validationException != null) {
-			BindException target = findCause(rootFailure, BindException.class);
+			BindException bindException = findCause(rootFailure, BindException.class);
 			List<ObjectError> errors = validationException.getValidationErrors().getAllErrors();
-			return new ExceptionDetails(errors, target, validationException);
+			return new ExceptionDetails(errors, bindException.getTarget().getType(), validationException);
 		}
 		org.springframework.validation.BindException bindException = findCause(rootFailure,
 				org.springframework.validation.BindException.class);

diff --git a/...ava/org/springframework/boot/diagnostics/analyzer/BindValidationFailureAnalyzerTests.java b/...ava/org/springframework/boot/diagnostics/analyzer/BindValidationFailureAnalyzerTests.java
@@ -63,9 +63,11 @@ void cleanup() {
 	@Test
 	void bindExceptionWithFieldErrorsDueToValidationFailure() {
 		FailureAnalysis analysis = performAnalysis(FieldValidationFailureConfiguration.class);
-		assertThat(analysis.getDescription()).contains(failure("test.foo.foo", "null", "must not be null"));
-		assertThat(analysis.getDescription()).contains(failure("test.foo.value", "0", "at least five"));
-		assertThat(analysis.getDescription()).contains(failure("test.foo.nested.bar", "null", "must not be null"));
+		assertThat(analysis.getDescription()).contains(failure("test.foo.foo", "null", "must not be null"))
+			.contains(failure("test.foo.value", "0", "at least five"))
+			.contains(failure("test.foo.nested.bar", "null", "must not be null"))
+			.contains(
+					"Binding to target org.springframework.boot.diagnostics.analyzer.BindValidationFailureAnalyzerTests$FieldValidationFailureProperties failed:");
 	}
 
 	@Test