Merge pull request eclipse-paho#1023 from fpagliughi/bool_update_conn…

…ect_options

Removed hard-coded 1 as truth in updateConnectOptions callback return

src/MQTTAsync.h

@@ -470,6 +470,12 @@ typedef struct
 
 #define MQTTAsync_connectData_initializer {{'M', 'Q', 'C', 'D'}, 0, NULL, {0, NULL}}
 
+/**
+ * This is a callback function which will allow the client application to update the 
+ * connection data.
+ * @param data The conneciton data which can be modified by the application.
+ * @return Return a non-zero value to update the connect data, zero to keep the same data.
+ */
 typedef int MQTTAsync_updateConnectOptions(void* context, MQTTAsync_connectData* data);
 
 /**

src/MQTTAsyncUtils.c

@@ -1687,7 +1687,7 @@ static void MQTTAsync_checkTimeouts(void)
 					Log(TRACE_MIN, -1, "Calling updateConnectOptions for client %s", m->c->clientID);
 					callback_rc = (*(m->updateConnectOptions))(m->updateConnectOptions_context, &connectData);
 
-					if (callback_rc == 1)
+					if (callback_rc)
 					{
 						if (connectData.username != m->c->username)
 						{